Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change variable name to condom_change_year_i #289

Merged
merged 7 commits into from
May 23, 2024

Conversation

jennifersmith203
Copy link
Collaborator

Variable previously called condom_incr_year_i but condom use does not necessarily increase. Changing to be consistent with MIHPSA Zim code

@@ -17003,7 +17002,7 @@ if 15 <= age and (death = . or caldate&j = death ) then do;

s_all_prep_criteria + all_prep_criteria ; s_all_prep_criteria_hivneg + all_prep_criteria_hivneg; s_prep_elig_hivneg + prep_elig_hivneg ;
s_prep_elig_hivneg_onprep + prep_elig_hivneg_onprep ; s_prep_elig_onprep + prep_elig_onprep ;s_prep_elig_onprep_inj + prep_elig_onprep_inj;
s_started_prep_inj_hiv + started_prep_inj_hiv; s_prep_elig_onprep_vr + prep_elig_onprep_vr; s_started_prep_vr_hiv + started_prep_vr_hiv;
s_started_prep_oral_hiv + started_prep_oral_hiv; s_started_prep_inj_hiv + started_prep_inj_hiv; s_prep_elig_onprep_vr + prep_elig_onprep_vr; s_started_prep_vr_hiv + started_prep_vr_hiv;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed that here you added:

  • s_started_prep_oral_hiv
  • s_prep_elig_onprep_vr
    Is it intentional that you added the latter?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that s_prep_elig_onprep_vr was already there but the order is a bit confusing and I can also see that s_prep_elig_onprep_oral doesn't exist. I will add that in and reorder the outputs so it's a bit clearer. Now inputted is:

s_prep_elig_onprep s_prep_elig_onprep_oral s_prep_elig_onprep_inj s_prep_elig_onprep_vr 
s_started_prep_any_hiv s_started_prep_oral_hiv s_started_prep_inj_hiv s_started_prep_vr_hiv

Copy link
Collaborator

@ValentinaCambiano ValentinaCambiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left a comment, otherwise fine with me

@andrew-phillips-1
Copy link
Collaborator

Jenny I noticed in the self-testing code we have "eponart=1" when this should be "epart=1" Could you please add to this PR ?

@jennifersmith203
Copy link
Collaborator Author

Hi Andrew, thanks - I've made that change.

@jennifersmith203 jennifersmith203 merged commit c6a1168 into core May 23, 2024
1 check passed
@jennifersmith203 jennifersmith203 deleted the update-naming-condom-change branch May 23, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants