Skip to content

Commit

Permalink
Add CI
Browse files Browse the repository at this point in the history
  • Loading branch information
zjkmxy committed Nov 11, 2023
1 parent 55f1687 commit edab9ad
Showing 1 changed file with 47 additions and 0 deletions.
47 changes: 47 additions & 0 deletions .github/workflows/deploy-firebase.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# Simple workflow for deploying static content to GitHub Pages
name: Deploy to Firebase Hosting on merge

This comment has been minimized.

Copy link
@yoursunny

yoursunny Nov 11, 2023

Does this app actually work on Firebase Hosting?
As far as I know, you cannot connect to ws: WebSocket from https: webpage.
https://community.cloudflare.com/t/load-insecure-ws-websocket-on-secure-httpssite-instead-of-wss-with-some-redirect/190381

This comment has been minimized.

Copy link
@zjkmxy

zjkmxy Nov 11, 2023

Author Collaborator

Yes. ws://localhost is considered as an exception, and test bed nodes support wss.

This comment has been minimized.

Copy link
@yoursunny

yoursunny Nov 12, 2023

pulsejet/ndn-play#1
According to this report, whether an https: webpage can use ws://localhost is browser specific.

This comment has been minimized.

Copy link
@zjkmxy

zjkmxy Nov 12, 2023

Author Collaborator

Unfortunately this app has to focus on Chrome-kernel browsers. Firefox and Safari does not fully support File System Access API, and may also have other issues. We may consider officially test and support other browsers later.
The current official support list is Chrome 119+ and Edge 119+.


on:
# Runs on pushes targeting the default branch
push:
branches: ['main']

# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:

# Sets the GITHUB_TOKEN permissions to allow deployment to GitHub Pages
permissions:
contents: read
pages: write
id-token: write

# Allow one concurrent deployment
concurrency:
group: 'pages'
cancel-in-progress: true

jobs:
# Single deploy job since we're just deploying
deploy:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- uses: pnpm/action-setup@v2
with:
version: 8
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: 21
cache: 'pnpm'
- name: Install dependencies
run: pnpm install
- name: Build
run: pnpm build
- uses: FirebaseExtended/action-hosting-deploy@v0
with:
repoToken: '${{ secrets.GITHUB_TOKEN }}'
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_ZJKMXY }}'
channelId: live
projectId: zjkmxy

0 comments on commit edab9ad

Please sign in to comment.