Skip to content

Commit

Permalink
Merge branch 'main' into APPS-2870_bug-text-is-truncated
Browse files Browse the repository at this point in the history
  • Loading branch information
jendiamond authored Aug 9, 2024
2 parents 71523fa + 3560fc1 commit 0cb7bd8
Show file tree
Hide file tree
Showing 6 changed files with 98 additions and 47 deletions.
4 changes: 2 additions & 2 deletions gql/queries/FTVAEventDetail.gql
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,10 @@ query FTVAEventDetail($slug: [String!]) {
slug
typeHandle
title
ftvaEvent {
ftvaEvent(startDateWithTime: ">= now") {
... on ftvaEvent_ftvaEvent_Entry {
id
to: uri
to: slug
title: eventTitle
startDate: startDateWithTime @formatDateTime(format: "Y-m-d", timezone: "America/Los_Angeles")
startTime: startDateWithTime @formatDateTime(format: "TH:i:s", timezone: "America/Los_Angeles")
Expand Down
8 changes: 4 additions & 4 deletions gql/queries/FTVAEventList.gql
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
#import "../gql/fragments/Image.gql"
# import "../gql/fragments/Image.gql"

query FTVAEventList {
entries(section: ["ftvaEvent"], orderBy: "postDate") {
typeHandle
id
title: eventTitle
to: uri
image: ftvaImage {
...Image
}
# image: ftvaImage {
# ...Image
# }
startDateWithTime
startDate: startDateWithTime @formatDateTime(format: "Y-m-d", timezone: "America/Los_Angeles")
startTime: startDateWithTime @formatDateTime(format: "TH:i:s", timezone: "America/Los_Angeles")
Expand Down
8 changes: 4 additions & 4 deletions gql/queries/FTVAEventSeriesList.gql
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#import "../gql/fragments/Image.gql"
# import "../gql/fragments/Image.gql"

query FTVAEventSeriesList {
entries(section: ["ftvaEventSeries"], orderBy: "postDate") {
Expand All @@ -9,9 +9,9 @@ query FTVAEventSeriesList {
... on ftvaEventSeries_eventSeries_Entry {
id
eventDescription
image: ftvaImage {
...Image
}
# image: ftvaImage {
# ...Image
# }
startDate @formatDateTime(format: "Y-m-d", timezone: "America/Los_Angeles")
endDate @formatDateTime(format: "Y-m-d", timezone: "America/Los_Angeles")
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@
"nuxt-graphql-request": "^7.0.5",
"sass": "^1.66.1",
"ucla-library-design-tokens": "^5.20.0",
"ucla-library-website-components": "3.5.7"
"ucla-library-website-components": "3.6.4"
}
}
63 changes: 32 additions & 31 deletions pages/events/[slug].vue
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const route = useRoute()
// DATA
const { data, error } = await useAsyncData(`events-detail-${route.params.slug}`, async () => {
const data = await $graphql.default.request(FTVAEventDetail, { slug: route.params.slug })
console.log('data', data)
return data
})
if (error.value) {
Expand All @@ -27,7 +26,6 @@ if (error.value) {
}
if (!data.value.ftvaEvent) {
// console.log('no data')
throw createError({
statusCode: 404,
statusMessage: 'Page Not Found',
Expand All @@ -48,6 +46,7 @@ watch(data, (newVal, oldVal) => {
const parsedImage = computed(() => {
return page.value.imageCarousel
})
// Transform data for Carousel
const parsedCarouselData = computed(() => {
// map image to item, map creditText to credit
Expand All @@ -61,25 +60,33 @@ const parsedCarouselData = computed(() => {
})
})
const pageId = computed(() => {
return page.value.id
})
const parsedFtvaEventSeries = computed(() => {
// const series = parsedFtvaEventSeries
const seriesEvents = series.value[0].ftvaEvent.map((obj) => {
return {
...obj,
image: obj.image[0]
}
})
/* Early Returns: If series.value is falsy or empty, or
if firstSeries.ftvaEvent is falsy or empty, return
an empty array immediately. */
if (!series.value || series.value.length === 0) {
return []
}
const [firstSeries] = series.value
if (!firstSeries.ftvaEvent || firstSeries.ftvaEvent.length === 0) {
return []
}
// Destructure each series item object and its image object
const seriesEvents = firstSeries.ftvaEvent.map(({ image, ...rest }) => ({
...rest,
image: image && image.length > 0 ? image[0] : null,
}))
const pageId = page.value.id
const events = seriesEvents.filter((item) => {
return item.id !== pageId // remove this page's event from the series list to avoid duplicate info
})
// return first 3 events
return events.slice(0, 3)
// Return series without the page's featured event
const filteredEvents = seriesEvents.filter(({ id }) => id !== pageId)
// Return first 3 events
return filteredEvents.slice(0, 3)
})
const parsedFTVAEventScreeningDetails = computed(() => {
Expand All @@ -98,7 +105,10 @@ const parsedFTVAEventScreeningDetails = computed(() => {
class="page page-event-detail"
>
<div class="one-column">
<NavBreadcrumb class="breadcrumb" />
<NavBreadcrumb
class="breadcrumb"
:title="page.title"
/>
<ResponsiveImage
v-if="parsedImage.length === 1"
Expand Down Expand Up @@ -174,23 +184,20 @@ const parsedFTVAEventScreeningDetails = computed(() => {
</div>
<div class="full-width">
<SectionWrapper
v-if="series && series.length > 0"
v-if="parsedFtvaEventSeries && parsedFtvaEventSeries.length > 0"
section-title="Upcoming events in this series"
theme="paleblue"
>
<SectionTeaserCard
v-if="series && series.length > 0"
v-if="parsedFtvaEventSeries && parsedFtvaEventSeries.length > 0"
:items="parsedFtvaEventSeries"
/>
</SectionWrapper>
</div>
</main>
</template>
<style
lang="scss"
scoped
>
<style lang="scss" scoped>
// VARS - TO DO move to global? reference tokens?
// WIDTH, HEIGHT, SPACING
$max-width: 1160px;
Expand Down Expand Up @@ -253,12 +260,6 @@ $pale-blue: #E7EDF2;
display: none;
}
:deep(figure.responsive-video) {
.sizer {
height: 568px; // TODO ask UX if FTVA videos on this page have fixed height or not
}
}
.sidebar-column {
min-width: 314px;
width: 30%;
Expand Down
60 changes: 55 additions & 5 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0cb7bd8

Please sign in to comment.