Skip to content

Commit

Permalink
fix: APPS-2998 Update inline carousels with new prop (#49)
Browse files Browse the repository at this point in the history
* task: update library components pkg from 3.27 to 3.28

* update: add inline prop to inline carousels

---------

Co-authored-by: tinuola <tinuola@users.noreply.github.com>
  • Loading branch information
tinuola and tinuola authored Oct 8, 2024
1 parent d0c54a7 commit ee5fe12
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 10 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@
"nuxt-graphql-request": "^7.0.5",
"sass": "^1.66.1",
"ucla-library-design-tokens": "^5.22.0",
"ucla-library-website-components": "3.26.0"
"ucla-library-website-components": "3.28.0"
}
}
1 change: 1 addition & 0 deletions pages/events/[slug].vue
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ const parsedFTVAEventScreeningDetails = computed(() => {
<FlexibleMediaGalleryNewLightbox
data-test="image-carousel"
:items="parsedCarouselData"
inline="true"
>
<template #default="slotProps">
<BlockTag
Expand Down
10 changes: 5 additions & 5 deletions pages/series/[slug].vue
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,10 @@ onMounted(() => {
v-else
class="lightbox-container"
>
<FlexibleMediaGalleryNewLightbox :items="parsedCarouselData">
<FlexibleMediaGalleryNewLightbox
:items="parsedCarouselData"
inline="true"
>
<template #default="slotProps">
<BlockTag :label="parsedCarouselData[slotProps.selectionIndex]?.creditText" />
</template>
Expand Down Expand Up @@ -312,10 +315,7 @@ onMounted(() => {
</main>
</template>
<style
lang="scss"
scoped
>
<style lang="scss" scoped>
// GENERAL PAGE STYLES / DESKTOP
.page-event-series-detail {
position: relative;
Expand Down
11 changes: 7 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 comment on commit ee5fe12

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.