Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APPS-2870 Page TextDescription and GuestSpeakerre-arranged to fix text truncation problem #19

Merged
merged 9 commits into from
Aug 9, 2024
Merged

fix: APPS-2870 Page TextDescription and GuestSpeakerre-arranged to fix text truncation problem #19

merged 9 commits into from
Aug 9, 2024

Conversation

jendiamond
Copy link
Member

@jendiamond jendiamond commented Aug 7, 2024 •
edited
Loading

Connected to APPS-2870 && PR

  1. This is the Nuxt part of this ticket to move the guestSpeaker into the CardMeta and the textDescription into a RichText component
  2. This PR also contains changes to the Cypress tests to not take a screenshot of the home page and names the screenshot on the eventDetails page

Checklist:

  • I added a github label for semantic versioning
  • I double checked it looks like the designs

@jendiamond jendiamond added the fix label Aug 7, 2024
@jendiamond jendiamond self-assigned this Aug 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-19--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-19 August 7, 2024 22:56 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-19 August 7, 2024 23:10 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-19 August 7, 2024 23:43 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-19 August 7, 2024 23:49 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-19 August 8, 2024 00:01 Inactive
@jendiamond jendiamond changed the title fix: APPS-2870 Component CardMeta in RichText - Text is truncated when it shouldn't be fix: APPS-2870 Page TextDescription and GuestSpeakerre-arranged to fix text truncation problem Aug 9, 2024
@github-actions github-actions bot temporarily deployed to pull_request-19 August 9, 2024 20:29 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-19 August 9, 2024 20:32 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-19 August 9, 2024 20:38 Inactive
@jendiamond jendiamond force-pushed the APPS-2870_bug-text-is-truncated branch from 76052dc to 71523fa Compare August 9, 2024 20:44
@jendiamond jendiamond force-pushed the APPS-2870_bug-text-is-truncated branch from 0cb7bd8 to b0ef43d Compare August 9, 2024 20:46
pghorpade
pghorpade approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pghorpade pghorpade merged commit c2dd3c2 into main Aug 9, 2024
10 checks passed
@pghorpade pghorpade deleted the APPS-2870_bug-text-is-truncated branch August 9, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pghorpade pghorpade pghorpade approved these changes

Assignees

@jendiamond jendiamond

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jendiamond @pghorpade