fix: set aspect ratio for images #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm. |
|
🚀 Deployed on https://deploy-preview-21--test-ftva.netlify.app |
jendiamond
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-2880
Notes:
The image at the top of the page should have a ratio of 1 (tall) to 2.31 (long), which works out to 1/2.31 = ~.43103
Responsive Image component expects this as a percentage so the prop is passed as 43.103.
Once that was fixed, it was noticed that the blue banner at the top of the screen needed an aspect ratio as well, so that was set.
I also fixed the issue with the pagelayout rendering the credit text whether or not there was any.
UX reported that the carousel should be changed to the same aspect ratio, so I added that to the APPS-2844
Time Report:
It took me 4 hours to build & test this.
Checklist:
[ ] I completed any required mobile breakpoint styling[ ] I completed any required hover state styling[ ] I included a working spec file