Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS-2757 Assemble default layout with footer variations #28

Merged

Conversation

jendiamond
Copy link
Member

@jendiamond jendiamond commented Aug 14, 2024

Connected to APPS-2757

Page/Pages Created/updated: {filename}.vue from #{issue number}

Notes:

{Any notes about what you built. How does it work? Anything missing?}

Checklist:

  • I added github label for semantic versioning
  • [] I double checked it looks like the designs
  • [] I completed any required mobile breakpoint styling
  • [] I completed any required hover state styling
  • [] I included a working spec file
  • [] I added notes above about how long it took to build this component
  • [] UX has reviewed this PR
  • [] I assigned this PR to someone to review

@jendiamond jendiamond self-assigned this Aug 14, 2024
Copy link

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link

github-actions bot commented Aug 14, 2024

🚀 Deployed on https://deploy-preview-28--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-28 August 14, 2024 17:23 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-28 August 14, 2024 22:44 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-28 August 15, 2024 23:36 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-28 August 16, 2024 03:02 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-28 August 16, 2024 04:16 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-28 August 16, 2024 17:01 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-28 August 16, 2024 18:10 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-28 August 16, 2024 18:16 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-28 August 16, 2024 20:33 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-28 August 17, 2024 00:47 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-28 August 17, 2024 01:12 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-28 August 19, 2024 20:35 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-28 August 20, 2024 18:23 Inactive
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jendiamond jendiamond merged commit 5b3a632 into main Aug 20, 2024
8 checks passed
@jendiamond jendiamond deleted the APPS-2757_assemble-default-layout-with-footer-variations branch August 20, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants