feat: APPS-2928 prerendering error pages and draft previews layout #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm. |
|
🚀 Deployed on https://deploy-preview-36--test-ftva.netlify.app |
pghorpade
changed the title
jendiamond
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-2928
More Info: nuxt/nuxt#18718 (comment)
Note: Also this PR deletes unwanted gql file to clean up our queries folder.
To test this, you need to be on UCLA vpn.
Broken layout on draft preview on test-ftva https://test-ftva.netlify.app/events/test-draft-previews?preview=true&x-craft-preview=9P76hQVN4a&token=_Ssd0CZRCv2zjRqUhY1AU5JMz-WMaNrI
Fixed Draft preview on this PR https://deploy-preview-36--test-ftva.netlify.app/events/test-draft-previews?preview=true&x-craft-preview=9P76hQVN4a&token=_Ssd0CZRCv2zjRqUhY1AU5JMz-WMaNrI
Error page layout data/state lost on test-ftva https://test-ftva.netlify.app/events/test-draft-previews
Fixed Error page layout data/state refetched on client side in this PR https://deploy-preview-36--test-ftva.netlify.app/events/test-draft-previews
Will remove the console.logs once it is working on test-ftva site