Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APPS 2927 Update Header query #38

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Sep 5, 2024

Connected to APPS-2927

Notes:

  • Updated component library to new version: 3.12.0
  • Updated header data query

Checklist:

  • I added github label for semantic versioning
  • I requested a PR review from the dev team
  • [ ] I double checked it looks like the designs
  • [ ] I completed any required mobile breakpoint styling
  • [ ] I completed any required hover state styling
  • [ ] I included a working spec file
  • [ ] I added notes above about how long it took to build this component
  • [ ] UX has reviewed this PR

@tinuola tinuola added the fix label Sep 5, 2024
@tinuola tinuola self-assigned this Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link

github-actions bot commented Sep 5, 2024

🚀 Deployed on https://deploy-preview-38--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-38 September 5, 2024 21:01 Inactive
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pghorpade pghorpade merged commit a98e08a into main Sep 5, 2024
8 checks passed
@pghorpade pghorpade deleted the APPS-2927_update-header-query branch September 5, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants