feat: APPS-2910 assemble event series page #39
Conversation
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm. |
|
🚀 Deployed on https://deploy-preview-39--test-ftva.netlify.app |
pages/series/[slug].vue
Outdated
| return upcomingEvents.value.map((item, index) => { | ||
| return { | ||
| ...item, | ||
| image: item.image[0] |
There was a problem hiding this comment.
Make it fail safe:
image: item.image && item.image.length > 0 ? item.image[0] : null
pages/series/[slug].vue
Outdated
| return pastEvents.value.map((item, index) => { | ||
| return { | ||
| ...item, | ||
| image: item.image[0] |
There was a problem hiding this comment.
Make it fail safe:
image: item.image && item.image.length > 0 ? item.image[0] : null
| return [] | ||
|
|
||
| let otherSeries = otherSeriesUpcoming.value.concat(otherSeriesOngoing.value) | ||
| // Get first 3 events |
There was a problem hiding this comment.
we need to further filter the array by removing current series like
// Return series without the page's featured event otherSeries = otherSeries.filter(({ to }) => !to.includes(route.params.slug) )
…d upcomming events cards, also needed to add to and parent-tiltle to navbreadcrum for event slug due to to bug in nav-breadcrumb
Connected to APPS-2910
Page/Pages Created/updated: [slug].vue
Notes:
Styles:
For the first page I added most styles directly to the page, including some global variables.
Because we are reusing a lot of these styles across pages, I have moved reused styles to global.scss to prevent duplication and keep things DRY
MOBILE:
The mockups for this page show complex behavior for the sidebar content (the previously sticky sidebar needs to split into 2 distinct content blocks and slot into 2 different areas in the column). This work is not 100% done, and will be continued in this ticket https://uclalibrary.atlassian.net/browse/APPS-2946
BLOCKCARDTHREECOLUMN:
Fixed in this commit
Currently the links do not work, I believe this is because of the way card-meta implements links using formatLinkTarget, this will likely need to be fixed next week as it cannot be fixed from the page side.Time Report:
This took me 10-12 hours to build this.
Checklist: