Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS-2955 remaining components #43

Merged
merged 13 commits into from
Oct 2, 2024

Conversation

farosFreed
Copy link
Contributor

@farosFreed farosFreed commented Sep 26, 2024

Connected to APPS-2955

Page/Pages Created/updated: /blog/[slug].vue from APPS-2955

Notes:

  • Updated package to latest components
  • Added cypress test for blog page
  • Added sidebar to blog page
  • Added Share Dropdown Button and new CardMeta dateCreated data
  • Added a computed method to parse images from recentPosts data
  • Slight edit to FTVAArticleDetail.gql to return 4 items instead of 3, as well as computed method to parse current article out of data
  • Slight edit to categories logic to reduce # of lines (this is a matter of opinion and we can revert this if we want the longer -but possibly more readable- version)
  • Tested and removed some junk data from carousel (also removed same junk data from /events/[slug].vue)
  • Tweaked column widths to match this figma file https://www.figma.com/design/L8e1czKo8a8px368ayyPZ4/%5BFTVA%5D-Final-Design-with-Annotations?node-id=28-3222&node-type=canvas&t=LQoUm8iQxVU7xSqX-0
  • Since many flexible blocks are not designed for small screens, we make the primary column 100% of the layout width when we get to 1200px
  • Setup Recent Posts section with SectionTeaserCard & 'View All Series >' link
  • Verified dates were showing in SectionTeaserCard after latest package update

Time Report:

6ish hours so far off and on

Checklist:

  • I added github label for semantic versioning
  • I double checked it looks like the designs
  • I completed any required mobile breakpoint styling
  • I completed any required hover state styling
  • I included a working spec file
  • I added notes above about how long it took to build this component
  • UX has reviewed this PR
  • I assigned this PR to someone to review

@farosFreed farosFreed self-assigned this Sep 26, 2024
Copy link

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link

github-actions bot commented Sep 26, 2024

🚀 Deployed on https://deploy-preview-43--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-43 September 26, 2024 19:47 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-43 September 26, 2024 23:37 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-43 September 27, 2024 17:28 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-43 September 27, 2024 17:50 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-43 October 1, 2024 17:26 Inactive
@farosFreed farosFreed marked this pull request as ready for review October 1, 2024 17:50
@github-actions github-actions bot temporarily deployed to pull_request-43 October 1, 2024 21:54 Inactive
pages/blog/[slug].vue Outdated Show resolved Hide resolved
pages/blog/[slug].vue Show resolved Hide resolved
pages/blog/[slug].vue Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull_request-43 October 1, 2024 23:33 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-43 October 2, 2024 16:24 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-43 October 2, 2024 16:51 Inactive
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@farosFreed farosFreed merged commit a04b977 into main Oct 2, 2024
8 checks passed
@farosFreed farosFreed deleted the APPS-2955_remaining_components_blog_layout branch October 2, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants