Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apps-2975 implement 2col on event detail, slot event detail in new position #46

Merged
merged 6 commits into from
Oct 3, 2024

Conversation

farosFreed
Copy link
Contributor

@farosFreed farosFreed commented Oct 2, 2024

Connected to APPS-2975

Page/Pages Created/updated: /events/[slug].vue

Notes:

  • Re-factored page to use the 2colwstickysidebar component
  • Slotted components so that EventDetail component will appear just under the title in cardmeta on mobile.

Time Report:

This took me 3ish hours to build this.

Checklist:

  • I added github label for semantic versioning
  • I double checked it looks like the designs
  • I completed any required mobile breakpoint styling
  • I completed any required hover state styling
  • I included a working spec file
  • I added notes above about how long it took to build this component
  • UX has reviewed this PR
  • I assigned this PR to someone to review

@farosFreed farosFreed self-assigned this Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link

github-actions bot commented Oct 2, 2024

🚀 Deployed on https://deploy-preview-46--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-46 October 2, 2024 18:02 Inactive
@farosFreed farosFreed changed the title Apps 2975 implement 2col event detail feat: Apps-2975 implement 2col on event detail, slot event detail in new position Oct 2, 2024
@farosFreed farosFreed marked this pull request as ready for review October 2, 2024 18:05
@github-actions github-actions bot temporarily deployed to pull_request-46 October 2, 2024 19:57 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-46 October 3, 2024 16:22 Inactive
@farosFreed farosFreed changed the title feat: Apps-2975 implement 2col on event detail, slot event detail in new position fix: Apps-2975 implement 2col on event detail, slot event detail in new position Oct 3, 2024
@farosFreed farosFreed added bugfix and removed feature labels Oct 3, 2024
@farosFreed farosFreed merged commit 862acfc into main Oct 3, 2024
8 checks passed
@farosFreed farosFreed deleted the APPS-2975_implement_2col_event_detail branch October 3, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants