Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apps-2996 add collection route and gql #48

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

farosFreed
Copy link
Contributor

@farosFreed farosFreed commented Oct 7, 2024

Connected to APPS-2996

Page/Pages Created/updated: /collections/index.vue, /collections/[slug].vue from #APPS-2996

Notes:

This PR adds:

collections/index.vue

  • GQL query to feed data to page
  • An index.vue page with the same layout / styles as the previous listing pages.
  • Since we were duplicating the styles each time for these listing pages, I have also moved the styles into a listing-page style file and imported it into all listing pages instead. This should be easier to improve and maintain.

collections/[slug].vue

  • GQL query to feed data to page
  • Existing components hooked up to data

Cypress tests were not mentioned on this ticket so I have left them to the next ticket. Let me know if I missed these.

Time Report:

This took me 12ish hours so far, including time spent in craft CMS and reviewing the page request

Checklist:

  • I added github label for semantic versioning
  • [ ] I double checked it looks like the designs
  • [ ] I completed any required mobile breakpoint styling
  • [ ] I completed any required hover state styling
  • [ ] I included a working spec file
  • I added notes above about how long it took to build this component
  • [ ] UX has reviewed this PR
  • I assigned this PR to someone to review

@farosFreed farosFreed self-assigned this Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link

github-actions bot commented Oct 7, 2024

🚀 Deployed on https://deploy-preview-48--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-48 October 7, 2024 23:41 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-48 October 10, 2024 19:53 Inactive
@farosFreed farosFreed marked this pull request as ready for review October 10, 2024 19:57
@tinuola tinuola merged commit 7801c1d into main Oct 10, 2024
8 checks passed
@tinuola tinuola deleted the APPS-2996_add-collection-route-and-gql branch October 10, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants