Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APPS-2998 Update inline carousels with new prop #49

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Oct 8, 2024

Connected to APPS-2998

Pages Updated:

  • pages/events/[slug].vue
  • pages/series/[slug].vue

Notes:

  • Updated library component package from 3.27.0 to 3.28.0 to include FTVA variants of MediaGallery components
  • Add inline=true to inline use cases of MediaGalleryNewLightbox

Deploy Previews:


Local Previews:
Event page - Inline Carousel:

event-page


Series page - Inline Carousel:

series-page


Blog page - Lightbox:

blog-page


Checklist:

  • I added github label for semantic versioning
  • I double checked it looks like the designs
  • [ ] I completed any required mobile breakpoint styling
  • [ ] I completed any required hover state styling
  • [ ] I included a working spec file
  • [ ] I added notes above about how long it took to build this component
  • [ ] UX has reviewed this PR
  • I requested a PR review from the Dev team

@tinuola tinuola added the fix label Oct 8, 2024
@tinuola tinuola self-assigned this Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link

github-actions bot commented Oct 8, 2024

🚀 Deployed on https://deploy-preview-49--test-ftva.netlify.app

Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pghorpade pghorpade merged commit ee5fe12 into main Oct 8, 2024
22 checks passed
@pghorpade pghorpade deleted the APPS-2998_update-inline-carousel-prop branch October 8, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants