Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: APPS-3000 Update FTVA Globals Query #50

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Oct 8, 2024

Connected to APPS-3000

Page Updated:

  • /server/api/fetchNitroStorageCraftGlobalData.js

Notes:

  • Update query

Checklist:

  • I added github label for semantic versioning
  • [ ] I double checked it looks like the designs
  • [ ] I completed any required mobile breakpoint styling
  • [ ] I completed any required hover state styling
  • [ ] I included a working spec file
  • [ ] I added notes above about how long it took to build this component
  • [ ] UX has reviewed this PR
  • I assigned this PR to someone to review

@tinuola tinuola added the chore label Oct 8, 2024
@tinuola tinuola self-assigned this Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link

github-actions bot commented Oct 8, 2024

🚀 Deployed on https://deploy-preview-50--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-50 October 8, 2024 22:03 Inactive
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pghorpade pghorpade merged commit 6020f41 into main Oct 9, 2024
8 checks passed
@pghorpade pghorpade deleted the APPS-3000_ftva-globals-alert-store branch October 9, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants