Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: APPS-2974 add title of entry as value for <title> tag in template #53

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

farosFreed
Copy link
Contributor

@farosFreed farosFreed commented Oct 15, 2024

Connected to APPS-2974 and APPS-2964

Notes:

APPS-2974

  • updated package.json
  • added useHead to all existing [slug].vue pages

APPS-2964

  • remove '.' from end of text when no past or upcoming events

Time Report:

This took me 4ish hours to build this, including time to read the ticket and documentation.

Checklist:

  • I added github label for semantic versioning
  • I double checked it looks like the designs
  • [] I completed any required mobile breakpoint styling
  • [ ] I completed any required hover state styling
  • [ ] I included a working spec file
  • I added notes above about how long it took to build this component
  • [ ] UX has reviewed this PR
  • I assigned this PR to someone to review

Copy link

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@farosFreed farosFreed self-assigned this Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

🚀 Deployed on https://deploy-preview-53--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-53 October 15, 2024 20:56 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-53 October 15, 2024 22:12 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-53 October 15, 2024 22:18 Inactive
@farosFreed farosFreed marked this pull request as ready for review October 15, 2024 22:18
@tinuola tinuola merged commit 2e5861c into main Oct 16, 2024
10 checks passed
@tinuola tinuola deleted the APPS-2974-title-tag-in-template branch October 16, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants