Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APPS-3009 Increase heapsize for production build #54

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Oct 16, 2024

Connected to APPS-3009

Notes:

  • updated heapsize from 8096 to 12288
  • commented out console statements in the code

Checklist:

  • I added github label for semantic versioning
  • I have requested a PR review from the Dev team
  • [ ] I double checked it looks like the designs
  • [ ] I completed any required mobile breakpoint styling
  • [ ] I completed any required hover state styling
  • [ ] I included a working spec file
  • [ ] I added notes above about how long it took to build this component
  • [ ] UX has reviewed this PR

@tinuola tinuola added the fix label Oct 16, 2024
@tinuola tinuola self-assigned this Oct 16, 2024
Copy link

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link

github-actions bot commented Oct 16, 2024

🚀 Deployed on https://deploy-preview-54--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-54 October 16, 2024 20:44 Inactive
Copy link
Member

@jendiamond jendiamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍦

@jendiamond jendiamond merged commit fdf4a7f into main Oct 16, 2024
10 checks passed
@jendiamond jendiamond deleted the APPS-3009_increase-heap-size branch October 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants