Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS-2743 Assemble the EventDetail page #6

Merged
merged 24 commits into from
Jul 29, 2024

Conversation

jendiamond
Copy link
Member

@jendiamond jendiamond commented Jul 24, 2024

Connected to APPS-2743

Page/Pages Created/updated: /events/slug.vue

Notes:

Ftva Theme with Ftva component variations added to the page.
We have created a spreadsheet to track bugs and missing features.
We had to remove the header and footer from the layout as it distorts the layout due to hydration or header data is not refreshed in preview mode.

Next step write better spec for this template.

Time Report:

It took us a couple of days to build this.

Checklist:

  • I added github label for semantic versioning
  • I double checked it looks like the designs
  • I completed any required mobile breakpoint styling
  • I completed any required hover state styling
  • I included a working spec file
  • I added notes above about how long it took to build this component
  • UX has reviewed this PR
  • I assigned this PR to someone to review

@jendiamond jendiamond self-assigned this Jul 24, 2024
Copy link

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link

github-actions bot commented Jul 24, 2024

🚀 Deployed on https://deploy-preview-6--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-6 July 24, 2024 20:04 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-6 July 24, 2024 21:43 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-6 July 24, 2024 22:33 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-6 July 25, 2024 09:46 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-6 July 25, 2024 16:55 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-6 July 25, 2024 23:59 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-6 July 26, 2024 20:00 Inactive
Jess Divers added 2 commits July 26, 2024 13:34
…the-event-detail-page' into APPS-2743_assemble-the-event-detail-page
@github-actions github-actions bot temporarily deployed to pull_request-6 July 26, 2024 20:39 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-6 July 26, 2024 23:44 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-6 July 27, 2024 00:07 Inactive
pages/events/[slug].vue Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull_request-6 July 29, 2024 17:21 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-6 July 29, 2024 18:34 Inactive
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 well done team

@github-actions github-actions bot temporarily deployed to pull_request-6 July 29, 2024 22:21 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-6 July 29, 2024 22:28 Inactive
@pghorpade pghorpade merged commit 5f7a5f6 into main Jul 29, 2024
8 checks passed
@pghorpade pghorpade deleted the APPS-2743_assemble-the-event-detail-page branch July 29, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants