-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APPS-2743 Assemble the EventDetail page #6
Conversation
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm. |
🚀 Deployed on https://deploy-preview-6--test-ftva.netlify.app |
…the-event-detail-page' into APPS-2743_assemble-the-event-detail-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 well done team
Connected to APPS-2743
Page/Pages Created/updated: /events/slug.vue
Notes:
Ftva Theme with Ftva component variations added to the page.
We have created a spreadsheet to track bugs and missing features.
We had to remove the header and footer from the layout as it distorts the layout due to hydration or header data is not refreshed in preview mode.
Next step write better spec for this template.
Time Report:
It took us a couple of days to build this.
Checklist: