fix: refactor the bannerText byline (#502)

* fix: refactorr the bannerText byline * fix: update byline computed * fix: update the component library * fix: delete articleType * fix: delte
UCLALibrary · Oct 14, 2022 · da70abd · da70abd · github-actions · Oct 15, 2022
1 parent 3f8ad60
commit da70abd
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 12 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -40,7 +40,7 @@
         "sass": "^1.45.2",
         "sass-loader": "^10.1.1",
         "ucla-library-design-tokens": "^5.3.0",
-        "ucla-library-website-components": "^1.57.1",
+        "ucla-library-website-components": "^1.57.2",
         "vue-svg-loader": "^0.16.0",
         "vue-template-compiler": "^2.6.12"
     }

diff --git a/pages/about/blogs/_slug.vue b/pages/about/blogs/_slug.vue
@@ -12,8 +12,8 @@
             category="Blog"
             :title="page.title"
             :text="page.text"
-            :byline="parsedByline"
-            article-type="blogs"
+            :byline="parsedBylineBannerText"
+            :locations="page.locations"
         />
 
         <section-wrapper class="section-banner">
@@ -106,6 +106,14 @@ export default {
             })
         },
 
+        parsedBylineBannerText() {
+            return (this.page.contributors || []).map((entry) => {
+                return `${entry.byline} ${
+                    entry.title || entry.staffMember[0].title
+                }`
+            })
+        },
+
         parsedDate() {
             return format(new Date(this.page.dateCreated), "MMMM d, Y")
         },

diff --git a/pages/about/news/_slug.vue b/pages/about/news/_slug.vue
@@ -12,8 +12,8 @@
             category="Library News"
             :title="page.title"
             :text="page.text"
-            :byline="parsedByline"
-            article-type="news"
+            :byline="parsedBylineBannerText"
+            :locations="page.locations"
         />
 
         <section-wrapper class="section-banner">
@@ -106,6 +106,14 @@ export default {
             })
         },
 
+        parsedBylineBannerText() {
+            return (this.page.contributors || []).map((entry) => {
+                return `${entry.byline} ${
+                    entry.title || entry.staffMember[0].title
+                }`
+            })
+        },
+
         parsedDate() {
             return format(new Date(this.page.dateCreated), "MMMM d, Y")
         },