Merge pull request #555 from UCLALibrary/URS-574_Add_rel_attribute_to…

…_links Add rel=noopener to links with target=_blank
UCLALibrary · Jan 9, 2020 · 12b270c · 12b270c
2 parents cfe7169 + 468031f
commit 12b270c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/app/views/shared/_footer.html.erb b/app/views/shared/_footer.html.erb
@@ -1,7 +1,7 @@
 <footer>
   <div class='footer-wrapper'>
     <div class="col1">
-      <%= link_to(image_tag('logo/ucla-library-logo.svg', class: 'logo', alt: 'UCLA Library Logo'), 'https://www.library.ucla.edu/', target: '_blank') %>
+      <%= link_to(image_tag('logo/ucla-library-logo.svg', class: 'logo', alt: 'UCLA Library Logo'), 'https://www.library.ucla.edu/', target: '_blank', rel: 'noopener') %>
     </div>
     <div class="col2">
       <ul>
@@ -12,8 +12,8 @@
     </div>
     <div class="col3">
       <ul>
-        <li><%= link_to 'Visit Our Legacy Site', 'http://digital2.library.ucla.edu/', target: '_blank' %></li>
-        <li><%= link_to 'Give Us Feedback', 'https://forms.gle/x2BV9dJMK241VsAJA', target:'_blank' %></li>
+        <li><%= link_to 'Visit Our Legacy Site', 'http://digital2.library.ucla.edu/', target: '_blank', rel: 'noopener' %></li>
+        <li><%= link_to 'Give Us Feedback', 'https://forms.gle/x2BV9dJMK241VsAJA', target: '_blank', rel: 'noopener' %></li>
 
         <!--<li>Migration Updates</li>-->
       </ul>

diff --git a/app/views/shared/_header_navbar.html.erb b/app/views/shared/_header_navbar.html.erb
@@ -6,15 +6,15 @@ function toggleFunction() {
 
 <nav class='navbar beta-bar' style="display:<%= @display_option %>" id="yellowBar">
   <div class="beta-bar-wrapper">
-    <span class='beta-text'>Welcome to Digital Collections (Beta)! This site is growing each week as we migrate content from our <a href='http://digital2.library.ucla.edu/'  target='_blank'>Legacy Site</a>.</span>
+    <span class='beta-text'>Welcome to Digital Collections (Beta)! This site is growing each week as we migrate content from our <a href='http://digital2.library.ucla.edu/'  target='_blank' rel="noopener">Legacy Site</a>.</span>
     <span class='beta-close' onclick="toggleFunction()">Close<i class="fa fa-close"></i></span>
   </div>  
 </nav>
 
 <nav class='navbar navbar-expand-lg navbar-dark site-navbar' role='navigation'>
   <div class='container-fluid'>
     <div class='navbar-logo-block'>
-      <%= link_to(image_tag('logo/ucla-library-digital-collections_logo.svg', class: 'navbar-logo', alt: 'UCLA Library Digital Collections Logo'), root_path) %>
+      <%= link_to(image_tag('logo/ucla-library-digital-collections_logo.svg', class: 'navbar-logo', alt: 'UCLA Library Digital Collections Logo',), root_path) %>
       <span class='beta-logo'>BETA</span>
     </div>
 
@@ -25,7 +25,7 @@ function toggleFunction() {
     <div class='collapse navbar-collapse' id='user-util-collapse'>
       <ul class='navbar-nav nav ml-auto'>
         <li class='nav-item'><a href='/about'>About</a></li>
-        <li class='nav-item nav-item-feedback'><a href='https://forms.gle/x2BV9dJMK241VsAJA' target='_blank' >Give us feedback</a></li>
+        <li class='nav-item nav-item-feedback'><a href='https://forms.gle/x2BV9dJMK241VsAJA' target='_blank' rel="noopener" >Give us feedback</a></li>
       </ul>
     </div>