Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS-2680 html tags and "read more" button for the search results #1152

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

kethlinmil
Copy link
Collaborator

image

https://uclalibrary.atlassian.net/browse/APPS-2680

The button was temporary removed because of the "unexpeted behavior", which I think was caused by the "return" on line 32. But we don't know what was the issue, because the original task was lost on JIRA move.

@emcaulay
Copy link
Member

Hi Tatiana,
Thanks for attaching the screenshot. Is it possible to control the truncation to only occur at end of word? In this screen shot the truncation happens in the middle of the word "in". Right now the display is "Airing i..." and that looks unusual.

sourcefilter
sourcefilter previously approved these changes Aug 23, 2024
@kethlinmil
Copy link
Collaborator Author

@sourcefilter @emcaulay I've updated to not truncate in the middle of the word or number.
image

@sourcefilter sourcefilter merged commit 398dfdd into main Aug 29, 2024
8 checks passed
@sourcefilter sourcefilter deleted the APPS-2680-search-results branch August 29, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants