Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): Wrap dashboard title in t function #1933

Merged
merged 1 commit into from
Nov 4, 2024
Merged

(fix): Wrap dashboard title in t function #1933

merged 1 commit into from
Nov 4, 2024

Conversation

NethmiRodrigo
Copy link
Contributor

@NethmiRodrigo NethmiRodrigo commented Oct 29, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

This PR wraps the dashboard title in the i18n t function to make it translatable.

Screenshots

After fix:
Screenshot 2024-10-27 at 8 22 09 PM

Before fix:
Screenshot 2024-10-27 at 8 28 18 PM

Related Issue

Other

@NethmiRodrigo
Copy link
Contributor Author

@CynthiaKamau requesting your review please. Thanks

@ibacher
Copy link
Contributor

ibacher commented Oct 31, 2024

@CynthiaKamau Could you review this please?

@CynthiaKamau CynthiaKamau merged commit 5313b4f into UCSF-IGHS:dev Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CynthiaKamau CynthiaKamau CynthiaKamau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NethmiRodrigo @ibacher @CynthiaKamau