feat(DTFS2-7121): change response format to make mapping in DTFS easier

UK-Export-Finance · May 31, 2024 · 99287e1 · 99287e1
1 parent f4ca3ad
commit 99287e1
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 28 deletions.
diff --git a/src/modules/companies/companies.service.ts b/src/modules/companies/companies.service.ts
@@ -72,10 +72,8 @@ export class CompaniesService {
       industryClasses.forEach((industryClass) => {
         if (sicCode === industryClass.ukefIndustryId) {
           industries.push({
-            sector: {
-              code: industryClass.ukefSectorId.toString(),
-              name: industryClass.ukefSectorName,
-            },
+            code: industryClass.ukefSectorId.toString(),
+            name: industryClass.ukefSectorName,
             class: {
               code: industryClass.ukefIndustryId,
               name: industryClass.ukefIndustryName,

diff --git a/src/modules/companies/dto/get-company-response.dto.ts b/src/modules/companies/dto/get-company-response.dto.ts
@@ -14,10 +14,8 @@ export class GetCompanyResponse {
 }
 
 export class Industry {
-  sector: {
-    code: string;
-    name: string;
-  };
+  code: string;
+  name: string;
   class: {
     code: string;
     name: string;

diff --git a/src/modules/companies/examples/example-response-for-get-company-by-registration-number.json b/src/modules/companies/examples/example-response-for-get-company-by-registration-number.json
@@ -13,40 +13,32 @@
                 "code": "59112",
                 "name": "Video production activities"
             },
-            "sector":  {
-                "code": "1009",
-                "name": "Information and communication"
-            }
+            "code": "1009",
+            "name": "Information and communication"
         },
         {
             "class":  {
                 "code": "62012",
                 "name": "Business and domestic software development"
             },
-            "sector":  {
-                "code": "1009",
-                "name": "Information and communication"
-            }
+            "code": "1009",
+            "name": "Information and communication"
         },
         {
             "class":  {
                 "code": "62020",
                 "name": "Information technology consultancy activities"
             },
-            "sector":  {
-                "code": "1009",
-                "name": "Information and communication"
-            }
+            "code": "1009",
+            "name": "Information and communication"
         },
         {
             "class":  {
                 "code": "62090",
                 "name": "Other information technology service activities"
             },
-            "sector":  {
-                "code": "1009",
-                "name": "Information and communication"
-            }
+            "code": "1009",
+            "name": "Information and communication"
         }
     ]
 }
diff --git a/test/support/generator/get-company-generator.ts b/test/support/generator/get-company-generator.ts
@@ -152,10 +152,8 @@ export class GetCompanyGenerator extends AbstractGenerator<CompanyValues, Genera
     shuffleArray(findSectorIndustriesResponse);
 
     const industries: Industry[] = v.sicCodes.map((sicCode, index) => ({
-      sector: {
-        code: v.industrySectorCode.toString(),
-        name: v.industrySectorName,
-      },
+      code: v.industrySectorCode.toString(),
+      name: v.industrySectorName,
       class: {
         code: sicCode,
         name: v.industryClassNames[index],