ROD-92 Create a reference number page #49
+230
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # apps/rod/fields/index.js
|
update next step for /reference-number to be /your-documents as per AC5 in ticket the check your answers page isn't showing up as per the figma, needs a field that displays the type of reference numbers the user has selected (can be all of them) |
|
For all of your field names that you have added to this PR I would prefix them with 'rod' so it's easier to read, search for in IDE and some of these field names are already in use in other journeys e.g. enter-case-id is in CNC So I would change all these fields to 'rod-case-id' etc and update everywhere else they appear, you can use VSC change all occurrences so that nothing gets missed |
# Conflicts: # apps/rod/fields/index.js # apps/rod/index.js # apps/rod/sections/summary-data-sections.js # apps/rod/translations/src/en/fields.json # apps/rod/translations/src/en/pages.json # apps/rod/translations/src/en/validation.json
vivekkumar-ho
requested changes
Nov 7, 2024
vivekkumar-ho
approved these changes
Nov 7, 2024
# Conflicts: # apps/rod/index.js # apps/rod/translations/src/en/validation.json # assets/scss/app.scss
# Conflicts: # apps/rod/translations/src/en/fields.json # apps/rod/translations/src/en/validation.json
7 tasks
# Conflicts: # apps/rod/fields/index.js # apps/rod/index.js # apps/rod/translations/src/en/validation.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
ROD-92 - Create a reference number page - ROD main flow
Why?
Allows user to enter a reference number
How?
Testing?
Tested on local machine
Screenshots (optional)
Anything Else? (optional)
Check list
here is an example commit