rel/v0.7.0 #216
Merged
rel/v0.7.0 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a slight change from previous method of filtering out values within 1 ms of the main map upper limit, in this case T2.
Confusing having R2 (1/T2) and R2 (R squared measure of model fit). Given 1/T2 is rarely used, this option has been removed.
Means lots of the code can be shared between relaxometry methods. Also added documentation
Ended up being too specific to each method
Already had decent coverage from mapping tests, but this means its easier to isolate issues further down the line
Was causing tests to fail at the very end (upload of coverage)!
…misation Curve Fit Optimisation and R-Squared
Only runs for GE at the moment and results aren't verified!
Done at 30,000 ft so probably terrible.
Could it be that this is using too much memory for the Actions runner?
Includes skimage label function but none of the region props stuff
Also upgrade to codecov v3 in the hop that actually uploads more often
Hopefully it'll be added again in the future.
T2 StimFit and Shape Features Compatibility
Update PR Templates
Kept core packages that will effect results with more tight requirements though.
Add Python 3.11 Support
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 97.62% 97.91% +0.28%
==========================================
Files 41 48 +7
Lines 3581 4311 +730
==========================================
+ Hits 3496 4221 +725
- Misses 85 90 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Checklist
Pull Request
devtorel/v[x.y.z]CHANGELOG.mdfile with the new version number, release date and add the new features/fixes along with any tags of PRs/issuessetup.pyCITATION.cffrel/v[x.y.z]tomasterrel/v[x.y.z]intomasterrel/v[x.y.z]intodevPost Pull Request Checks