Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 237 commits into
base: feedback
Choose a base branch
from
Open

Feedback #1

wants to merge 237 commits into from

Conversation

github-classroom[bot]
Copy link
Contributor

@github-classroom github-classroom bot commented Mar 22, 2022

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.

Subscribed: @NikFBail @CBeane313 @krug0102 @Shua59

github-classroom bot and others added 30 commits March 1, 2022 20:59
Co-authored-by: CBeane313 <CBeane313@users.noreply.github.com>
Co-authored-by: Daniel Albright <albright220@users.noreply.github.com>
Co-authored-by: CBeane313 <CBeane313@users.noreply.github.com>
Co-authored-by: Daniel Albright <albright220@users.noreply.github.com>
Albright220/issue33 into cole-maxwell1/issue34
BSON requires ArrayLists rather than normal java arrays
This was causing an IOException.
We can try to fix it if we add images
Shua59 and others added 29 commits April 6, 2022 17:11
Ability to display number of items in a given category
Enables us to display the number of products in each category.
Fixes all the weird name change stuff with new category names
Reformatted document, and made category div flex
Also added a few tests.  Adding a new item to the pantry test seems to be weird with new database schema.
Adds client tests to increase coverage to "acceptable" levels
…g0102/issue6

Merges Josh's revised testing files into the MegaSuperSigmaOmegaMegaBranch that is issue6
Fixes checkstyle for line that was more than 120 char
Still not enough to pass coverage tests
fixed routing issue when adding product to pantry from product id page, now it properly redirects to pantry page
Tried to fix test addProduct() in PantryControllerSpec.java, ended up commenting out some changes to work on in later iteration
Implements the ability to remove an item from the pantry.
addProduct() test in PantryControllerSpec.java works, for got a freaking comma
Krug0102/issue6/addProductToPantryFromPantryPage
@lgtm-com
Copy link

lgtm-com bot commented Apr 7, 2022

This pull request introduces 13 alerts and fixes 1 when merging d5ea715 into a8c24d1 - view on LGTM.com

new alerts:

  • 13 for Unused variable, import, function or class

fixed alerts:

  • 1 for Use of a broken or risky cryptographic algorithm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants