Group users by company #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `usersByCompany` endpoint which returns the users (just ID and name) grouped by company. I had to create two new Java classes to capture the structure of these results. `UserGroupResult` (which should be renamed) holds the company (`_id`), the `count` (how many users work for that company), and `users` (a list of `UserIdName` objects). The `UserIdName` objects just contain the `_id` and `name` of a `User`. GitHub CoPilot was a huge help here, both in helping generate the queries, but also in debugging some `IOException` errors that were the result of mismatches between the structures being generated by the queries and my Java classes.
Both `UserByCompany` and `UserIdName` have `public` fields (generally bad, but necessary for Jackson/MongoDB), so we needed to suppress the `VisibilityModifier` warning. We also needed to suppress the `MemberName` warning for `_id` since Mongo requires that name.
I think this gets the `getUsersGroupedByCompany` in a pretty solid place.
This adds several tests that check the behavior of the `getUsersGroupedByCompany` functionality.
This adds the necessary bits to the routing and the `AppComponent` so that we display the new company view.
This generated the initial stubs with `ng generate`, and then provided a simple implementation of the component and the HTML file. This also adds the `Company` and `UserNameId` classes, which hold the necessary data.
I probably could have put this in a new `CompaniesService`, but I didn't want to mess with that right away. The fact that I ended up using `${enviornment.apiUrl}usersByCompany` instead of the `userUrl` probably is a strong argument that this should have been in a separate service.
I had hoped to fancy this up more (esp. the HTML), but it works and I need to go to bed. The one really nice thing is that I was able to use a `Signal` in the component to avoid having any subscriptions anywhere!
This wasn't actually passing because I hadn't sorted out the dependency on `UserService` yet.
NicMcPhee
commented
Feb 13, 2024
| // Look for a (sub)element with the company name | ||
| .contains(companyName) | ||
| // Return the containing company card element | ||
| .parents('.company-card'); |
There was a problem hiding this comment.
I'm not sure I'm thrilled about this "go down to the company name" and then "go up one step to the .company-card approach, but I'm not sure of a better way.
NicMcPhee
commented
Feb 13, 2024
| <mat-card-content> | ||
| <ul class="company-card-users"> | ||
| @for (user of this.company.users; track user._id) { | ||
| <li><span class="company-card-user-name">{{ user.name }}</span></li> |
There was a problem hiding this comment.
This isn't the most beautiful of UIs, and I'm sure we can make it nicer.
NicMcPhee
commented
Feb 13, 2024
|
|
||
| it('should create', () => { | ||
| expect(component).toBeTruthy(); | ||
| }); |
There was a problem hiding this comment.
At the moment all this tests is that this can be successfully constructed. We might want more testing here, although it's not entirely clear what we'd test. There's no real logic in the component except for the call to the userService. I guess we should check that the value of companies has the same number as in testCompanies.
NicMcPhee
added a commit
to UMM-CSci-3601/3601-iteration-template
that referenced
this pull request
Feb 22, 2024
This adds a new usersByCompany endpoint which returns the users (just ID and name) grouped by company. It supports two modifiers: sortBy and sortOrder. sortBy can be either company or count, and sortOrder can be either asc or desc. I had to create two new Java classes to capture the structure of these results. UserGroupResult (which should be renamed) holds the company (_id), the count (how many users work for that company), and users (a list of UserIdName objects). The UserIdName objects just contain the _id and name of a User. This is essentially a copy of the changes in PR 81 in Lab 4: UMM-CSci-3601/3601-lab4-mongo#81 GitHub CoPilot was a huge help here, both in helping generate the queries, but also in debugging some IOException errors that were the result of mismatches between the structures being generated by the queries and my Java classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
usersByCompanyendpoint which returns the users (just ID and name) grouped by company. It supports two modifiers:sortByandsortOrder.sortBycan be eithercompanyorcount, andsortOrdercan be eitherascordesc.I had to create two new Java classes to capture the structure of these results.
UserGroupResult(which should be renamed) holds the company (_id), thecount(how many users work for that company), andusers(a list ofUserIdNameobjects). TheUserIdNameobjects just contain the_idandnameof aUser.GitHub CoPilot was a huge help here, both in helping generate the queries, but also in debugging some
IOExceptionerrors that were the result of mismatches between the structures being generated by the queries and my Java classes.