Maze generation and integration with fish npc #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aze file to ensure it works.
…he main game. Fixed code modulaity
This was
linked to
issues
Sep 17, 2024
Closed
davidaraba
approved these changes
Sep 19, 2024
jt-09
approved these changes
Sep 19, 2024
reemmi
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Looks good to me, definitely NEED more/more thorough documentation throughout but you guys have time to fix that up and code coverage isn't amazing but for base functionality it works. Again just working on breaking up some methods. Other than that it's good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request integrates the new underwater maze mini-game with the fish npc.
The current game randomises the maze design and we have implemented a light radius (controlled with wads or arrows).
Screen should resize appropreiately. Additionally, a return to game button for the end game screen has been implemented when the mini-game is played from the main game.
Extensive testing and further game development is needed but integration with main game and maze design is complete. (Do note that some files will have a lot more work done specifically MazeGameScreen and MazeGame)
Feature: Underwater Maze Mini-Game #333
Task Tickets:
Underwater Maze Design #378
Integration of Underwater Maze Mini-Game with Fish NPC #377