Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maze Mini-Game Entities and Game Mechanics #436

Merged
merged 122 commits into from
Oct 1, 2024
Merged

Maze Mini-Game Entities and Game Mechanics #436

merged 122 commits into from
Oct 1, 2024

Conversation

EllaBerglas
Copy link
Contributor

Description

This is the same pull request as #420 but had to be remade as the original one accientally closed.

This pull reqest implements all entities, health and combat, maze collisoin and AI path finding.
All entities inlcude:

  • Angular fish
  • Player fish
  • Jelly Fish
  • Eels
  • Fish eggs
    Eels and angular fish can chase the player. Jelly fish and angular fish can damage the player. Fish eggs are not interactable. Fish eggs collection, score and game termination is not in this pul request and will be completed by the end of sprint 3. Eels will have a stun affect that will also be impelmented in future pull request.

Fixes / Closes
Part of Feature ticket #333
Jelly fish #411
Fish eggs #368
Angular Fish #413
Path finidng #414
Eels #415
Health #416
maze collision detection #417
Player (animations and image) #419

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Visual tests
  • MazeCombatStatsComponentTest
  • MazePlayerFactoryTest
  • MazeTest
  • JellyfishTest
  • ElectricEelsTest
  • AngularFishTest
  • FishEggTest
  • MazeObsticleTest
  • MazeNPCFactoryTest
    Note that we will complete more comprehensive tests when feature is fully completed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

jakingy and others added 30 commits September 20, 2024 21:04
… angler fish method to inlcude ai tasks within that method.
…to be spawned in as an argument. Changed jellyfish light colour
Copy link
Contributor

@jt-09 jt-09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Game looks really good! Great modularity of code and classes. Good to see ample unit testing

Copy link
Contributor

@TarushiG TarushiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new elements added! Great functionality & testing practices.

Copy link
Contributor

@reemmi reemmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Game looks really great! Testing is great and so is the documentation. Good job :)

@EllaBerglas EllaBerglas merged commit 9ee5120 into main Oct 1, 2024
2 checks passed
Copy link
Contributor

@nreyana nreyana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!! yayyy good job!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants