-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarking and documentation re: super_partition()
#32
Comments
Yes, happy to work on it! In terms of vignettes, either way is fine with me. It's not very much new material, so adding it to the intro vignette seems reasonable, or we could do a larger example with a GEO dataset and create a new vignette. |
One option for a larger example is to do I'll leave it up to you, though. If you think there are things worth clarifying with a longer example, we should do that. If you think it's enough to show the basics in existing documentation because the pattern of use is the same, that's also reasonable. BTW for the benchmarking, I believe I did some trickery so that it doesn't run every time, meaning you can do a longer example. For this particular problem, you could also run the benchmarks in another repository and save the results to use in the README here. That assumes that it'd be helpful to show it in a larger example that would be impractical to include in this repo. Again, I'll trust your judgment on what is the best demonstration of |
I think the basics are sufficient. The only new thing in the I'm not sure how useful the benchmarks will be, but I am including them in my dissertation, so I will run them regardless. If they add new information compared to whats already in the README, we'll add them, and if not, they will only exist for my dissertation. |
That makes sense. Re: benchmarks, just a suggestion. I'll leave it all to you. If and when you publish on this, make sure to add a citation to the documentation here! |
@katelynqueen98 I'm going to move ahead with a submission to CRAN without these additions for the sake of a release for your paper. Feel free to add them later, and I'll do a patch release |
@katelynqueen98, after #29 is merged, I think we should consider adding a few supporting elements to the package documentation:
partition()
documentationThe other thing I was thinking about is if there should be a benchmark example like the ones in the current README
The text was updated successfully, but these errors were encountered: