Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-alloc] pimAlloc updates #165

Open
wants to merge 40 commits into
base: dev-alloc
Choose a base branch
from
Open

[dev-alloc] pimAlloc updates #165

wants to merge 40 commits into from

Conversation

deyuan
Copy link
Collaborator

@deyuan deyuan commented Oct 2, 2024 •
edited
Loading

PR to dev-alloc for early review and incremental development. Will not merge to main until finalized.

Below changes have been merged to main as PR #168:

  • Remove bitsPerElement parameter from pimAlloc and pimAllocAssociated. Auto derive bitsPerElement from data type.
  • Add pimUtils::getNumBitsOfDataType
  • Add misc-bench folder to top-level Makefile
  • Fix a bug in scale and warnings in bitmap and xor

Current changes:

  • Add pimAllocCustomized and pimAllocAssociatedCustomized for supporting different bitsPerElement as needed.
  • pimResMgr changes from previous PR Support padding during allocation #129
  • Add PIM_BOOL data type
  • Add test-padding testcase

Related issue: #16

@deyuan deyuan changed the title [dev-alloc] [dev-alloc] pimAlloc updates Oct 2, 2024
@deyuan deyuan changed the base branch from main to dev-alloc October 2, 2024 14:42
@deyuan deyuan mentioned this pull request Oct 3, 2024
Merged
fasiddique
fasiddique approved these changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@fasiddique fasiddique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fzx333 and others added 14 commits October 17, 2024 14:59
Fixed FP divscalar result bias issue. Due to compiler optimization no…
b1b5ef0 
…t compliant with IEEE FP standard, changed -Ofast to -O3.
Adding FP32 support for pimRedSum, all other operations are supported!
d798755
Merge branch 'main' into dev_float_support
c619a79
FP32 functional support for all operations completed!
03de35a
@deyuan
Merge with the latest main branch.
c72f925
@deyuan
Organize customized APIs in libpimeval.h
41c56f5
FP support, only redSumRanged left.
90f9138
Code clean up.
ab5ca02
@fzx333 @deyuan
Update libpimeval/src/pimCmd.cpp
95fa27a 
Co-authored-by: Deyuan Guo <guodeyuan@gmail.com>
@fzx333 @deyuan
Update libpimeval/src/pimCmd.cpp
5c22506 
Co-authored-by: Deyuan Guo <guodeyuan@gmail.com>
@fzx333 @deyuan
Update libpimeval/src/pimCmd.cpp
9f8ec8a 
Co-authored-by: Deyuan Guo <guodeyuan@gmail.com>
@fzx333 @deyuan
Update tests/test-functional/test-functional-fp.h
22495a9 
Co-authored-by: Deyuan Guo <guodeyuan@gmail.com>
All operation suppoerted.
1378d5e
Updated golden results.
39cbf1b
deyuan and others added 18 commits October 22, 2024 00:59
@deyuan
Resolve an assertion in FP32 reduction sum perf energy model on bit-s…
9908918 
…erial PIM.
@deyuan
Support fuzzy equal check with a percentage tolerance for FP reductio…
75bc6f4 
…n sum results.
@deyuan
Update result-golden.txt for functional testing
5d7b865
@fasiddique
GOL code cleanup
0977455
@Arleee1
GOL code cleanup (#191)
af887c5
@fasiddique
test device API bugfix. code cleanup for test large copies.
72f9e9f
@deyuan
FP32 functional support for all operation completed! (#189)
bec79fe
@deyuan
PIMeval: test cleanup (#192)
5fb02fd
@fasiddique
bitmap, xor codecleanup
4def6dd
@fasiddique
code cleanup gemv & pool
2938617
@fasiddique
relu & batched-relu code cleanup
b6186ce
@fasiddique
relu code cleanup
3e3a7e8
@fasiddique
code cleanup convolution
24ee191
@fasiddique
batched convolution code cleanup
83f95e3
@fasiddique
Bitmap, xor code cleanup (#196)
84c9485
@fasiddique
Merge branch 'main' into pimbench-code-cleanup
d0781a9
@fasiddique
Pimbench code cleanup (#197)
e039afd
@deyuan
Merge branch 'main' into deyuan_dev2
45d597f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasiddique fasiddique fasiddique approved these changes

@mhgholamrezaei mhgholamrezaei Awaiting requested review from mhgholamrezaei

@Morteza1814 Morteza1814 Awaiting requested review from Morteza1814

@fzx333 fzx333 Awaiting requested review from fzx333

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deyuan @fasiddique @fzx333 @Arleee1