Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Remove bitsPerElement parameter from default pimAlloc and pimAllocAssociated #168

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

deyuan
Copy link
Collaborator

@deyuan deyuan commented Oct 3, 2024

PR #165 combines multiple changes to dev-alloc branch, which is hard to review. I would suggest we merge this batch of changes to main first for API updates that touch all benchmark apps.

List of changes:

  • Remove bitsPerElement parameter from pimAlloc and pimAllocAssociated. Auto derive bitsPerElement from data type by calling newly added pimUtils::getNumBitsOfDataType. Currently all bitsPerElement parameters match with given data type exactly, so they can be safely removed.
  • Add misc-bench folder to top-level Makefile. Currently it is not compiled.
  • Fix a bug in scale (incorrect associated obj) and print warnings in bitmap and xor.

Copy link
Collaborator

@fasiddique fasiddique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fasiddique fasiddique merged commit 81a101c into main Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants