PIMbench Min/max Reduce API #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasiddique
reviewed
Oct 22, 2024
fasiddique
reviewed
Oct 22, 2024
fasiddique
reviewed
Oct 22, 2024
fasiddique
reviewed
Oct 22, 2024
deyuan
reviewed
Oct 24, 2024
deyuan
reviewed
Oct 24, 2024
deyuan
reviewed
Oct 24, 2024
deyuan
reviewed
Oct 24, 2024
deyuan
requested changes
Oct 24, 2024
fasiddique
reviewed
Nov 5, 2024
fasiddique
reviewed
Nov 5, 2024
fasiddique
reviewed
Nov 5, 2024
yanhanBazoooka
force-pushed
the
hanyan
branch
from
c72c3b0 to
6ec224b
Compare
|
I tired to fix the unspecified error by casting float to pimRedMax/Min execution. (since we are using void* unlike specified types from redSum implementation.) Feels a bit dangerous. Also, the major blocker is that I can't figure out why I'm having error: ‘pimCmdRedSum’ was not declared in this scope; did you mean ‘pimRedSum’? This is from redSum but I didn't change the redSum implementation. As this is currently the only error that I'm having. |
yanhanBazoooka
force-pushed
the
hanyan
branch
from
c0a4906 to
4eb042c
Compare
fasiddique
reviewed
Dec 1, 2024
fasiddique
reviewed
Dec 1, 2024
fasiddique
reviewed
Dec 1, 2024
fasiddique
reviewed
Dec 1, 2024
fasiddique
reviewed
Dec 1, 2024
fasiddique
reviewed
Dec 1, 2024
fasiddique
reviewed
Dec 1, 2024
fasiddique
reviewed
Dec 1, 2024
fasiddique
changed the title
fasiddique
reviewed
Dec 2, 2024
fasiddique
reviewed
Dec 2, 2024
fasiddique
reviewed
Dec 2, 2024
fasiddique
reviewed
Dec 2, 2024
fasiddique
reviewed
Dec 2, 2024
Co-authored-by: Farzana Ahmed Siddique <fas9nw@virginia.edu>
Co-authored-by: Farzana Ahmed Siddique <fas9nw@virginia.edu>
Co-authored-by: Farzana Ahmed Siddique <fas9nw@virginia.edu>
fasiddique
reviewed
Dec 4, 2024
deyuan
requested changes
Dec 4, 2024
libpimeval/src/pimSim.cpp
Outdated
Comment on lines
756
to
757
| if (idxBegin != idxEnd && idxBegin < idxEnd) pimPerfMon perfMon("pimRedMinRanged"); | ||
| else pimPerfMon perfMon("pimRedMin"); |
There was a problem hiding this comment.
Suggested change
| if (idxBegin != idxEnd && idxBegin < idxEnd) pimPerfMon perfMon("pimRedMinRanged"); | |
| else pimPerfMon perfMon("pimRedMin"); | |
| std::string tag = (idxBegin != idxEnd && idxBegin < idxEnd) ? "pimRedMinRanged" : "pimRedMin"; | |
| pimPerfMon perfMon(tag); |
Please note that pimPerfMon is an on-stack object and its ctor-to-dtor lifetime needs to cover entire operation.
libpimeval/src/pimSim.cpp
Outdated
Comment on lines
805
to
806
| if (idxBegin != idxEnd && idxBegin < idxEnd) pimPerfMon perfMon("pimRedMaxRanged"); | ||
| else pimPerfMon perfMon("pimRedMax"); |
There was a problem hiding this comment.
Suggested change
| if (idxBegin != idxEnd && idxBegin < idxEnd) pimPerfMon perfMon("pimRedMaxRanged"); | |
| else pimPerfMon perfMon("pimRedMax"); | |
| std::string tag = (idxBegin != idxEnd && idxBegin < idxEnd) ? "pimRedMaxRanged" : "pimRedMax"; | |
| pimPerfMon perfMon(tag); |
libpimeval/src/pimSim.cpp
Outdated
Comment on lines
855
to
856
| if (idxBegin != idxEnd && idxBegin < idxEnd) pimPerfMon perfMon("pimRedSumRanged"); | ||
| else pimPerfMon perfMon("pimRedSum"); |
There was a problem hiding this comment.
Suggested change
| if (idxBegin != idxEnd && idxBegin < idxEnd) pimPerfMon perfMon("pimRedSumRanged"); | |
| else pimPerfMon perfMon("pimRedSum"); | |
| std::string tag = (idxBegin != idxEnd && idxBegin < idxEnd) ? "pimRedSumRanged" : "pimRedSum"; | |
| pimPerfMon perfMon(tag); |
Comment on lines
+16
to
+26
| #include "pimCmd.h" | ||
| #include "pimSim.h" | ||
| #include "pimDevice.h" | ||
| #include "pimCore.h" | ||
| #include "pimResMgr.h" | ||
| #include <cstdio> | ||
| #include <cmath> | ||
| #include <unordered_map> | ||
| #include <unordered_set> | ||
| #include <climits> | ||
| #include <cmath> |
There was a problem hiding this comment.
Suggested change
| #include "pimCmd.h" | |
| #include "pimSim.h" | |
| #include "pimDevice.h" | |
| #include "pimCore.h" | |
| #include "pimResMgr.h" | |
| #include <cstdio> | |
| #include <cmath> | |
| #include <unordered_map> | |
| #include <unordered_set> | |
| #include <climits> | |
| #include <cmath> | |
| #include <cmath> | |
| #include <climits> |
| } | ||
| } | ||
| currIdx += 1; | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| //! @brief PIM CMD: redsum non-ranged/ranged - update stats |
There was a problem hiding this comment.
Please revert this deletion
fasiddique
reviewed
Dec 4, 2024
| { | ||
| // Reduction tree approach for min/max | ||
| unsigned levels = static_cast<unsigned>(std::ceil(std::log2(numElements))); // Tree depth | ||
| pimeval::perfEnergy perfEnergyBS = getPerfEnergyBitSerial(m_simTarget, PimCmdEnum::MIN, dataType, bitsPerElement, numPass, obj); |
There was a problem hiding this comment.
We need to add an entry for reduction Min/Max in the bitserial table and then cmdType should be passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented min/max reduce and added pimCmdReduction for sum min max all in one. (ideally).