Skip to content

Commit

Permalink
Add asgiref requirement to work with new simple-history version
Browse files Browse the repository at this point in the history
django-simple-history introduced a dependency on asgiref>=3.6 but
didn't include it in their requirements. Add this dependency at
least until we upgrade to Django 4.2. See issue:
jazzband/django-simple-history#1255
  • Loading branch information
amstilp committed Nov 16, 2023
1 parent d6eafff commit 22e67b6
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 3 deletions.
6 changes: 5 additions & 1 deletion requirements/dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
#
alabaster==0.7.13
# via sphinx
asgiref==3.5.1
appnope==0.1.3
# via ipython
asgiref==3.7.2
# via
# -c requirements/requirements.txt
# django
Expand Down Expand Up @@ -245,7 +247,9 @@ types-pyyaml==6.0.12.12
# via django-stubs
typing-extensions==4.8.0
# via
# -c requirements/requirements.txt
# -c requirements/test-requirements.txt
# asgiref
# astroid
# black
# django-stubs
Expand Down
4 changes: 4 additions & 0 deletions requirements/requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,7 @@ django-simple-history
# mysql
# Pinned because versions >=2.2 require pkg-config.
mysqlclient # https://github.com/PyMySQL/mysqlclient

# Required for django < 4.2 and django-simple-history is updated.
# See issue https://github.com/jazzband/django-simple-history/issues/1255
asgiref>=3.6
8 changes: 6 additions & 2 deletions requirements/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@ argon2-cffi==21.3.0
# via -r requirements/requirements.in
argon2-cffi-bindings==21.2.0
# via argon2-cffi
asgiref==3.5.1
# via django
asgiref==3.7.2
# via
# -r requirements/requirements.in
# django
async-timeout==4.0.2
# via redis
build==1.0.3
Expand Down Expand Up @@ -167,6 +169,8 @@ tomli==2.0.1
# build
# pip-tools
# pyproject-hooks
typing-extensions==4.8.0
# via asgiref
urllib3==1.26.9
# via requests
wheel==0.41.3
Expand Down
1 change: 1 addition & 0 deletions requirements/test-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ types-urllib3==1.26.25.14
# via types-requests
typing-extensions==4.8.0
# via
# -c requirements/requirements.txt
# django-test-migrations
# faker
urllib3==1.26.9
Expand Down

0 comments on commit 22e67b6

Please sign in to comment.