-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Face Bounds Construction #730
Comments
Re @philipc2's benchmarking:
That's extremely slow for such a small grid (though relatable as the algorithm iterates over each face, and each edge of that face). Taking into account bigger grids might be used, the execution times might make the things impractical, and that makes me think that we should consider either to optimize before a release, or provide caution admonitions, if possible, in the documentation to let the user clearly know the extreme performance bottleneck. Thoughts? Originally posted by @erogluorhan in #692 (review) |
Some for-loop-based code needs to be replaced with vectorized ones the issue #346. Though, as part of here (if #346 will take too long), should we still find some intermediate (though not ideal) solutions to make our code look better I believe (rather than using a for loop and list appends), e.g. something like the following?:
Originally posted by @erogluorhan in #692 (comment) |
We should also investigate the performance of lower-level helper functions that are called throughout.
|
Since the Thank you! |
Hey @hongyuchen1030, sure! |
Proposed new feature or change:
Optimize the performance when constructing
Grid.face_bounds
The text was updated successfully, but these errors were encountered: