Merge pull request #316 from Ubiquiti-App/feature/fio-plugin-settings…

…-form-validation-fix FIO plugin - settings form validation fix
Ubiquiti-App · Jan 5, 2024 · 035c541 · 035c541
2 parents 52b7548 + cc22bd9
commit 035c541
Show file tree

Hide file tree

Showing 8 changed files with 29 additions and 44 deletions.
diff --git a/plugins/fio_cz/fio_cz.zip b/plugins/fio_cz/fio_cz.zip
diff --git a/plugins/fio_cz/src/manifest.json b/plugins/fio_cz/src/manifest.json
@@ -5,7 +5,7 @@
     "displayName": "Fio bank payment import",
     "description": "This plugin enables you to import payments from Fio bank to UCRM. See https://www.fio.cz/bankovni-sluzby/api-bankovnictvi",
     "url": "https://github.com/Ubiquiti-App/UCRM-plugins/tree/master/plugins/fio_cz",
-    "version": "1.2.8",
+    "version": "1.2.9",
     "unmsVersionCompliancy": {
       "min": "2.1.0",
       "max": null
@@ -37,20 +37,26 @@
     {
       "key": "importUnattached",
       "label": "Import all payments.",
-      "description": "Import all payments. Payments without match will be imported as \"Unattached payments\". Fill 1 to enable or 0 to disable this feature (when disabled, the unmatched payment will only be logged and skipped).",
-      "required": 1,
+      "description": "Import all payments. Payments without match will be imported as \"Unattached payments\". When disabled, the unmatched payment will only be logged and skipped.",
+      "required": 0,
       "type": "checkbox"
     },
     {
       "key": "lastProcessedPayment",
-      "label": "Last processed payment",
+      "label": "Last processed payment ID (readonly)",
       "description": "Internal payment tracking to avoid duplicate processing of the same payment",
       "required": 0,
       "type": "text"
     },
+    {
+      "key": "lastProcessedPaymentDateTime",
+      "label": "Last processed payment date and time (readonly)",
+      "required": 0,
+      "type": "datetime"
+    },
     {
       "key": "lastProcessedTimestamp",
-      "label": "Last time the payment list was requested",
+      "label": "Last time the payment list was requested (readonly)",
       "description": "Internal timestamp tracking to politely avoid API request rate limits",
       "required": 0,
       "type": "text"

diff --git a/plugins/fio_cz/src/src/Data/PluginData.php b/plugins/fio_cz/src/src/Data/PluginData.php
@@ -6,38 +6,17 @@
 
 class PluginData extends UcrmData
 {
-    /**
-     * @var string
-     */
-    public $lastProcessedPayment;
-
-    /**
-     * @var string
-     */
-    public $paymentMatchAttribute;
-
-    /**
-     * @var string
-     */
-    public $startDate;
-
-    /**
-     * @var string
-     */
-    public $token;
-
-    /**
-     * @var string
-     */
-    public $lastProcessedTimestamp;
-
-    /**
-     * @var string
-     */
-    public $importUnattached;
-
-    /**
-     * @var string
-     */
-    public $lastProcessedPaymentDateTime;
+    public string $lastProcessedPayment;
+
+    public string $paymentMatchAttribute;
+
+    public string $startDate;
+
+    public string $token;
+
+    public string $lastProcessedTimestamp;
+
+    public string $importUnattached;
+
+    public string $lastProcessedPaymentDateTime;
 }
diff --git a/plugins_2.1.x.json b/plugins_2.1.x.json
@@ -31,7 +31,7 @@
             "displayName": "Fio bank payment import",
             "description": "This plugin enables you to import payments from Fio bank to UCRM. See https:\/\/www.fio.cz\/bankovni-sluzby\/api-bankovnictvi",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/fio_cz",
-            "version": "1.2.8",
+            "version": "1.2.9",
             "unmsVersionCompliancy": {
                 "min": "2.1.0",
                 "max": null

diff --git a/plugins_2.2.x.json b/plugins_2.2.x.json
@@ -31,7 +31,7 @@
             "displayName": "Fio bank payment import",
             "description": "This plugin enables you to import payments from Fio bank to UCRM. See https:\/\/www.fio.cz\/bankovni-sluzby\/api-bankovnictvi",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/fio_cz",
-            "version": "1.2.8",
+            "version": "1.2.9",
             "unmsVersionCompliancy": {
                 "min": "2.1.0",
                 "max": null

diff --git a/plugins_2.3.x.json b/plugins_2.3.x.json
@@ -31,7 +31,7 @@
             "displayName": "Fio bank payment import",
             "description": "This plugin enables you to import payments from Fio bank to UCRM. See https:\/\/www.fio.cz\/bankovni-sluzby\/api-bankovnictvi",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/fio_cz",
-            "version": "1.2.8",
+            "version": "1.2.9",
             "unmsVersionCompliancy": {
                 "min": "2.1.0",
                 "max": null

diff --git a/plugins_2.4.x.json b/plugins_2.4.x.json
@@ -31,7 +31,7 @@
             "displayName": "Fio bank payment import",
             "description": "This plugin enables you to import payments from Fio bank to UCRM. See https:\/\/www.fio.cz\/bankovni-sluzby\/api-bankovnictvi",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/fio_cz",
-            "version": "1.2.8",
+            "version": "1.2.9",
             "unmsVersionCompliancy": {
                 "min": "2.1.0",
                 "max": null

diff --git a/plugins_2.5.x.json b/plugins_2.5.x.json
@@ -31,7 +31,7 @@
             "displayName": "Fio bank payment import",
             "description": "This plugin enables you to import payments from Fio bank to UCRM. See https:\/\/www.fio.cz\/bankovni-sluzby\/api-bankovnictvi",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/fio_cz",
-            "version": "1.2.8",
+            "version": "1.2.9",
             "unmsVersionCompliancy": {
                 "min": "2.1.0",
                 "max": null