UCRM 6305 - Dropbox plugin - Use writeStream()

Ubiquiti-App · Nov 29, 2024 · f396c4d · f396c4d
1 parent 04a8754
commit f396c4d
Show file tree

Hide file tree

Showing 10 changed files with 240 additions and 220 deletions.
diff --git a/plugins/backup-sync-dropbox/backup-sync-dropbox.zip b/plugins/backup-sync-dropbox/backup-sync-dropbox.zip
diff --git a/plugins/backup-sync-dropbox/src/composer.lock b/plugins/backup-sync-dropbox/src/composer.lock
diff --git a/plugins/backup-sync-dropbox/src/manifest.json b/plugins/backup-sync-dropbox/src/manifest.json
@@ -5,7 +5,7 @@
         "displayName": "Backup synchronization - Dropbox",
         "description": "This plugin handles synchronization of your UNMS backups to a Dropbox folder.",
         "url": "https://github.com/Ubiquiti-App/UCRM-plugins/tree/master/plugins/backup-sync-dropbox",
-        "version": "1.2.0",
+        "version": "1.2.1",
         "unmsVersionCompliancy": {
             "min": "2.1.0",
             "max": null

diff --git a/plugins/backup-sync-dropbox/src/src/Facade/BackupFacade.php b/plugins/backup-sync-dropbox/src/src/Facade/BackupFacade.php
@@ -11,26 +11,11 @@
 
 final class BackupFacade
 {
-    /**
-     * @var UnmsApi
-     */
-    private $unmsApi;
-
-    /**
-     * @var Filesystem
-     */
-    private $filesystem;
-
-    /**
-     * @var LoggerInterface
-     */
-    private $logger;
-
-    public function __construct(UnmsApi $unmsApi, Filesystem $filesystem, LoggerInterface $logger)
-    {
-        $this->unmsApi = $unmsApi;
-        $this->filesystem = $filesystem;
-        $this->logger = $logger;
+    public function __construct(
+        private UnmsApi $unmsApi,
+        private Filesystem $filesystem,
+        private LoggerInterface $logger
+    ) {
     }
 
     public function upload(UnmsBackup $unmsBackup): void
@@ -41,7 +26,10 @@ public function upload(UnmsBackup $unmsBackup): void
             return;
         }
 
-        $this->filesystem->write($unmsBackup->filename, $this->unmsApi->get(sprintf('nms/backups/%s', $unmsBackup->id)));
+        $temp = tmpfile();
+        fwrite($temp, $this->unmsApi->get(sprintf('nms/backups/%s', $unmsBackup->id)));
+
+        $this->filesystem->writeStream($unmsBackup->filename, $temp);
 
         $this->logger->info(sprintf('Uploaded file "%s".', $unmsBackup->filename));
     }

diff --git a/plugins_2.1.x.json b/plugins_2.1.x.json
@@ -18,7 +18,7 @@
             "displayName": "Backup synchronization - Dropbox",
             "description": "This plugin handles synchronization of your UNMS backups to a Dropbox folder.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/backup-sync-dropbox",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "2.1.0",
                 "max": null

diff --git a/plugins_2.2.x.json b/plugins_2.2.x.json
@@ -18,7 +18,7 @@
             "displayName": "Backup synchronization - Dropbox",
             "description": "This plugin handles synchronization of your UNMS backups to a Dropbox folder.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/backup-sync-dropbox",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "2.1.0",
                 "max": null

diff --git a/plugins_2.3.x.json b/plugins_2.3.x.json
@@ -18,7 +18,7 @@
             "displayName": "Backup synchronization - Dropbox",
             "description": "This plugin handles synchronization of your UNMS backups to a Dropbox folder.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/backup-sync-dropbox",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "2.1.0",
                 "max": null

diff --git a/plugins_2.4.x.json b/plugins_2.4.x.json
@@ -18,7 +18,7 @@
             "displayName": "Backup synchronization - Dropbox",
             "description": "This plugin handles synchronization of your UNMS backups to a Dropbox folder.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/backup-sync-dropbox",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "2.1.0",
                 "max": null

diff --git a/plugins_2.5.x.json b/plugins_2.5.x.json
@@ -18,7 +18,7 @@
             "displayName": "Backup synchronization - Dropbox",
             "description": "This plugin handles synchronization of your UNMS backups to a Dropbox folder.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/backup-sync-dropbox",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "2.1.0",
                 "max": null

diff --git a/plugins_3.0.x.json b/plugins_3.0.x.json
@@ -18,7 +18,7 @@
             "displayName": "Backup synchronization - Dropbox",
             "description": "This plugin handles synchronization of your UNMS backups to a Dropbox folder.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/backup-sync-dropbox",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "2.1.0",
                 "max": null