Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature issue 15583 spiral z hop #17559

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

NadineMik
Copy link

@NadineMik NadineMik commented Dec 8, 2023

Description

This pull requests adds a tangential spiral z-hop and thus fixes this issue.
It provides a smooth spiral z-hop after a retraction, where the beginning and the end of the spiral (or arc) is tangential to the previous and following movement. Additionally, a retraction can be performed throughout the spiral. The z-height increases linearly throughout the spiral and the speed in xy-direction is kept constant relative to the previous movement. After the following travel a normal unretract and vertical un-z-hop is performed.
The full documentation on this feature can be found over here.
This pull request is paired with a pull request in cura engine over here.

Type of change

Only settings have been added inside cura. The remaining changes (logic) have been done in the cura engine.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Printer definition file(s)
  • Translations

How Has This Been Tested?

  • Checked that the new settings are visible in the UI and can be called from the engine.

Test Configuration:

  • Operating System:
  • Windows 10

Checklist:

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Dec 8, 2023
@NadineMik NadineMik marked this pull request as ready for review December 8, 2023 10:45
@saumyaj3 saumyaj3 self-assigned this Jan 10, 2024
@saumyaj3 saumyaj3 removed their assignment Jan 29, 2024
@wawanbreton wawanbreton added the PR: Slicing Process 🤯 Like fixing simplification, adding a new primetower, introducing tree support, correcting logging, o label Feb 16, 2024
Chore: Simplify the label for the minimal segment length used for discretization.

Co-authored-by: Saumya Jain <70144862+saumyaj3@users.noreply.github.com>
@MariMakes
Copy link
Contributor

Hey!

Welcome to the UltiMaker Cura Github 🚀
Sorry, it took us a while to get back to you 😞

We've added a ticket to the backlog so the team can test this functionality.
They are really excited to try it out, it looks very promising 😇
For internal reference CURA-11696

Thanks for your report.
Together we can make Cura better 😊

@MariMakes MariMakes added the Status: On Backlog The issue / feature has been reproduced and is deemed important enough to be fixed. label Apr 16, 2024
@NadineMik
Copy link
Author

Many thanks for the update! I am looking forward to your feedback!

@saumyaj3
Copy link
Contributor

Hi @NadineMik! First of all, I would like to thank you for taking out some time to implement this feature for Cura. However, We had some testing done on the feature you implemented for spiral z-hop. the results were not satisfying, so we are parking this PR for a while. One of the test prints for the spiral z-hop is mentioned below.

IMG_6349 (1)

Our testing team had some improvement points for the feature, I suppose you can work on these points once you get time?

  • Z hop type setting is not visible in experimental. It is also not visible when dual extrusion is on. Make sure this setting is available in experimental section and is also available in case of dual extrusion

  • "Z hop when retracted" is on by default. This should not be the case.

  • Spiral z hops makes the travel line (partly) dark blue (unretracted) also light blue (retracted). this shouldn't happen.

  • Default setting spiral radius is much too large: 10mm set to 1mm

  • No z movement is visible in the slice preview, both for vertical and spiral z hop at the moment. This code is to be looked into shaders.

  • There seems to be a bug in the time estimate. A PLA/PVA print of the autodesk model take 7h55min with a vertical hop and 7h24min with a spiral hop. Can not be true.

  • Also it looks like the spiral hop happens at one height while it should go up while doing the spiralling for blobs not to form.

Your help is much appreciated.

Thanks a ton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's PR: Slicing Process 🤯 Like fixing simplification, adding a new primetower, introducing tree support, correcting logging, o Status: On Backlog The issue / feature has been reproduced and is deemed important enough to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Spiral Z-Hop and Diagonal Z-Hop like BambuStudio and Orca Slicer
4 participants