-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature issue 15583 spiral z hop #17559
base: main
Are you sure you want to change the base?
Feature issue 15583 spiral z hop #17559
Conversation
…le with the engine spdlog version.
Chore: Simplify the label for the minimal segment length used for discretization. Co-authored-by: Saumya Jain <70144862+saumyaj3@users.noreply.github.com>
Hey! Welcome to the UltiMaker Cura Github 🚀 We've added a ticket to the backlog so the team can test this functionality. Thanks for your report. |
Many thanks for the update! I am looking forward to your feedback! |
Hi @NadineMik! First of all, I would like to thank you for taking out some time to implement this feature for Cura. However, We had some testing done on the feature you implemented for spiral z-hop. the results were not satisfying, so we are parking this PR for a while. One of the test prints for the spiral z-hop is mentioned below. Our testing team had some improvement points for the feature, I suppose you can work on these points once you get time?
Your help is much appreciated. Thanks a ton. |
Description
This pull requests adds a tangential spiral z-hop and thus fixes this issue.
It provides a smooth spiral z-hop after a retraction, where the beginning and the end of the spiral (or arc) is tangential to the previous and following movement. Additionally, a retraction can be performed throughout the spiral. The z-height increases linearly throughout the spiral and the speed in xy-direction is kept constant relative to the previous movement. After the following travel a normal unretract and vertical un-z-hop is performed.
The full documentation on this feature can be found over here.
This pull request is paired with a pull request in cura engine over here.
Type of change
Only settings have been added inside cura. The remaining changes (logic) have been done in the cura engine.
How Has This Been Tested?
Test Configuration:
Checklist: