-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change playback position freely during singing #449
Comments
I'm looking forward to this! |
Using this feature should immediately set the collected points for the current song back to 0. |
Currently there is my Mod for skipping back and forwards. But it doesn't reset the score. |
Unfortunately, it works with some bugs. Sometimes, it skips only the lyrics, leaving the audio intact. And if you scroll back, the lyrics do not return. |
singSceneControl.SkipToPosition(singSceneControl.PositionInMillis - secondsToSkip * 1000); I use this API of the SingSceneControl. So that would be a Bug in SingSceneControl in my opinion. |
I agree that the score should be reset to the value that the players had at this point in time when skipping backwards. However, the current skip function was intended to skip forward in the song, so no reset logic has been implemented yet. |
I'm sorry to be so hard, but I think this feature goes in the wrong direction. It blows up the code, making it more complex and messes up the core experience of the game. Is any commercial singing game doing this? |
This feature is implemented in Smule. it is adapted to the mobile interface. You need to click on the text located at the bottom of the screen, the full text will open along the text lines with the selection line, you need to slide to the desired line in the song and click on the text again to continue the song. In this application, this is implemented to record individual fragments of a song. It seems to me that in Melody Mania this can be used for training |
From a media player perspective, I think it makes sense to scroll back and forth through the song. So I think complexity for this feature is less on the user side and more on the development side. But I would not disqualify this only because it may be tricky to implement. Taking a step back and rethinking the current implementation might yield a better, more generic solution. Depends on implementation. |
Actual behaviour
Currently, one can "skip to next lyrics" when singing. But there is no way to jump back in the song.
Expected behaviour
One should be able to change the playback position freely (forward and backward) via the progress bar, like in other media players.
Note that this would make a dedicated learning mode obsolete: https://steamcommunity.com/app/2394070/discussions/0/4349990283304041849/
Implementation
Changing the playback position of the SongAudioPlayer is not an issue.
However, when jumping back in the song, then it should adjust the player's state accordingly, e.g., reset the score and sung notes.
Further, it would be nice if the timebar would show some indication of the position on hover, e.g., the time at this point or the next lyrics. This would make it clearer where the skip will lead before actually doing it.
The text was updated successfully, but these errors were encountered: