Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move settings for song select to song select #451

Open
achimmihca opened this issue Jun 28, 2024 · 0 comments
Open

Move settings for song select to song select #451

achimmihca opened this issue Jun 28, 2024 · 0 comments

Comments

@achimmihca
Copy link
Collaborator

achimmihca commented Jun 28, 2024

Actual behaviour

Currently, the "design" settings include some options that affect the song select.

Expected behaviour

The settings that affect the song select scene should be reachable from the song select scene, e.g., in an overlay, similar to the settings for the sing scene.

Implementation

The song select UI already has too many buttons.
Thus, I would first reduce visual complexity before introducing a new settings button.

Maybe some menu or toolbar that opens a popup on access could help.
For example, the App UI package has a VisualElement that shows only as much items as fitting inside its current area. This could make for a toolbar with auto-hiding toolbar buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant