Remove WebView #484
Draft
Remove WebView #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove all references to Vulpex WebView from the game.
Closes Issue(s)
None.
Motivation
It's dead code. Vulpex WebView itself cannot be included in this open source project. But also, even if we had an open source solution, scraping e.g. YouTube could get us into trouble. And given that 3rd party websites can change at any time, there is impossible to ensure good player experience.
More
None.
Additional Notes
This change risks causing a hard fork between UltraStar Play and Melody Mania.