Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

모달과 관련된 수정사항들 #9

Merged
merged 8 commits into from
Apr 20, 2022
Merged

모달과 관련된 수정사항들 #9

merged 8 commits into from
Apr 20, 2022

Conversation

nabi-chan
Copy link
Collaborator

@nabi-chan nabi-chan commented Apr 18, 2022 •
edited by BasixKOR
Loading

Close #8

  • Fix z-index of alert box
  • Move message to title
  • Add Color type at tailwindcss
  • Fix modal logic
  • Rename push to alert
  • Remove unused function close
  • Split Modal component

PINOT added 7 commits April 18, 2022 22:51
Fix z-index of alert box
d217df1
Move message to title
7b22f8c
Add Color type at tailwindcss
21a1f13
Fix modal logic
deb3115 
Promise를 씌우는 대신 Promise.resolve 를 동작시키도록 modal의 비즈니스 로직을 변경했습니다.
Rename push to alert
b16e0b3
Remove unused function close
7d683b8
Split Modal component
f1a60a5
@nabi-chan nabi-chan added the enhancement New feature or request label Apr 18, 2022
@nabi-chan nabi-chan requested review from JUSTIVE and BasixKOR April 18, 2022 15:00
@nabi-chan nabi-chan self-assigned this Apr 18, 2022
@vercel
Copy link

vercel bot commented Apr 18, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
umasupport-carrot ✅ Ready (Inspect) Visit Preview Apr 20, 2022 at 8:37AM (UTC)

BasixKOR
BasixKOR approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@BasixKOR BasixKOR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

components/Modal.tsx Outdated Show resolved Hide resolved
@nabi-chan nabi-chan merged commit 03d798e into main Apr 20, 2022
@nabi-chan nabi-chan deleted the enhancement/modal branch April 20, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BasixKOR BasixKOR BasixKOR approved these changes

@JUSTIVE JUSTIVE Awaiting requested review from JUSTIVE

Assignees

@nabi-chan nabi-chan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

modal 개선하기
2 participants
@nabi-chan @BasixKOR