Add fail_level argument and deprecate fail_on_error #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcransome
reviewed
Oct 9, 2024
Co-authored-by: Marc Ransome <marc.ransome@fidgetbox.co.uk>
Comment on lines
+26
to
+28
| fail_level: | ||
| Exit code for reviewdog when errors are found with severity greater than or equal to the given level [none,any,info,warning,error]. | ||
| Default is `none`. |
There was a problem hiding this comment.
Suggested change
| fail_level: | |
| Exit code for reviewdog when errors are found with severity greater than or equal to the given level [none,any,info,warning,error]. | |
| Default is `none`. | |
| fail_level: | |
| description: | | |
| Exit code for reviewdog when errors are found with severity greater than or equal to the given level [none,any,info,warning,error]. |
There was a problem hiding this comment.
@gaurav-nelson The fail_level input on line 26 needs to be indented two spaces in your suggested change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24.
This PR has two commits to make it easier to review:
fail_leveloption in the first commitfail_on_error=true.If backwards-compatibility isn't important, we can just go with the first commit and reduce the code complexity.