Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AttendanceRecord API endpoint #120

Open
1 of 5 tasks
aryanprince opened this issue Nov 28, 2023 · 0 comments
Open
1 of 5 tasks

Refactor AttendanceRecord API endpoint #120

aryanprince opened this issue Nov 28, 2023 · 0 comments
Assignees
@lewisj576
Labels
♻️ refactor Neither fixes a bug nor adds a feature
Milestone
Final Presentation

Comments

@aryanprince
Copy link
Member

  • Better naming instead of returnedData1, returnedData2, etc
  • More edge case checking like sending 404 if a student hasn't been enrolled
  • More comments explaining each step of the API since it's pretty long and does a lot of stuff
  • Check if student already has an AttendanceRecord for the same lectureId first
  • Check if student is trying to tap after the lectureEndTime
@aryanprince aryanprince added the ♻️ refactor Neither fixes a bug nor adds a feature label Nov 28, 2023
@aryanprince aryanprince added this to the Final Presentation milestone Nov 28, 2023
aryanprince added a commit that referenced this issue Nov 28, 2023
@aryanprince
perf: Reduced DB calls, improved error checks (#120)
3397125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lewisj576 lewisj576

Labels
♻️ refactor Neither fixes a bug nor adds a feature
Projects
None yet
Milestone
Final Presentation
Development

No branches or pull requests
2 participants
@aryanprince @lewisj576