Use install directory that matches package name #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow cmake
find_pacakge()search procedure rules, the install directory name should match the package name:https://cmake.org/cmake/help/v3.20/command/find_package.html#search-procedure
With this change, now
find_packageshould work even when specifying onlynetCDF-Fortran_ROOT(thus running in Config Mode), which has the highest search precedence since CMake 3.12Future improvements might include a variable to replace all instances of the string
netCDF-Fortranso that variables or functions that ought to use the package name can source from one definition.