Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F401 (unused imports) rule to ruff config #3026

Open
wants to merge 1 commit into
base: cleanup/add-noqa-to-necessary-unused-imports
Choose a base branch
from

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Sep 25, 2024

Depends on #3020.

This is just my suggestion. so please add your opinion if and why you think this is not a great idea.

@johannaengland johannaengland added the discussion Requires developer feedback/discussion before implementation label Sep 25, 2024
@johannaengland johannaengland self-assigned this Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.44s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Sep 25, 2024

Test results

    9 files      9 suites   8m 12s ⏱️
2 128 tests 2 128 ✅ 0 💤 0 ❌
3 995 runs  3 995 ✅ 0 💤 0 ❌

Results for commit 14a50e3.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.45%. Comparing base (2a2c093) to head (14a50e3).

Additional details and impacted files
@@                              Coverage Diff                              @@
##           cleanup/add-noqa-to-necessary-unused-imports    #3026   +/-   ##
=============================================================================
  Coverage                                         60.45%   60.45%           
=============================================================================
  Files                                               605      605           
  Lines                                             43799    43799           
  Branches                                             48       48           
=============================================================================
  Hits                                              26480    26480           
  Misses                                            17307    17307           
  Partials                                             12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland changed the base branch from master to cleanup/add-noqa-to-necessary-unused-imports September 27, 2024 09:06
@johannaengland johannaengland force-pushed the cleanup/add-noqa-to-necessary-unused-imports branch from f4eaae2 to 2a2c093 Compare September 27, 2024 09:07
Copy link

sonarcloud bot commented Sep 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked discussion Requires developer feedback/discussion before implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant