Remove setup.py once and for all
#3176
Open
+28
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 18s ⏱️ Results for commit 14f0073. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3176 +/- ##
=======================================
Coverage 60.39% 60.39%
=======================================
Files 605 605
Lines 43704 43704
Branches 48 48
=======================================
Hits 26396 26396
Misses 17296 17296
Partials 12 12 ☔ View full report in Codecov by Sentry. |
lunkwill42
requested review from
hmpf,
podliashanyk,
stveit and
johannaengland
podliashanyk
force-pushed
the
build-sass-with-webpack
branch
3 times, most recently
from
e1cebe3
to
19d7c58
Compare
libsass is gone, and `setuptools_scm` no longer requires `setup.py`, so our transition to using only `pyproject.toml` should be complete.
This removes mentions of the removed `setup.py` script, but also changes the installation guide to recommend a virtualenv for installing NAV. Using a virtualenv has become obligatory for Debian-based distros, unless everything is packaged as a .deb package.
These install docs were obsolete, and even more so now that `setup.py` is gone. Fixes #3141
There is no longer a `setup.py` in the source root, but rather `pyproject.toml`. This ensures the Docker container's verification that the source code seems to be mounted on `/source` is still up to snuff.
lunkwill42
force-pushed
the
cleanup/remove-setup-py
branch
from
65fcb83
to
14f0073
Compare
|
johannaengland
approved these changes
Nov 13, 2024
| @@ -90,13 +93,25 @@ the following command to build the CSS assets:: | |||
| This will build the CSS assets and place them in the :file:`python/nav/web/static/css` | |||
| directory. | |||
|
|
|||
| To build and install NAV and all its Python dependencies:: | |||
| We recommend installing NAV into a Python virtual environment, to avoid | |||
| interfering with your system-wide Python libraries. Pick a suitable path for | |||
There was a problem hiding this comment.
Suggested change
| interfering with your system-wide Python libraries. Pick a suitable path for | |
| interfering with your system-wide Python libraries. Pick a suitable path for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
libsassout of the way, andsetuptools_scmlong since updated, we no longer rely on having a minimalsetup.pypresent. It can be removed to complete the transition topyproject.toml.This PR removes the script and updates documentation and some scripts that referenced the old
setup.pyways (which means this also fixes #3141)