Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pydantic2 #20

Closed
wants to merge 7 commits into from
Closed

Use Pydantic2 #20

wants to merge 7 commits into from

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Jul 25, 2023

No description provided.

hmpf added 7 commits June 23, 2023 12:18
The EventEngine currently only supports the first load of events, not
updates.
It turns out that bump-pydantic only does so much. It didn't aattempt to
fix subclasses of BaseModel, fair.

Input to timedelta works different, on v1 you could build a timedelta
from an int of seconds stored in a string, in v2 it must be an int.
Interestingly the v1 docs does not mention that int-as-string is
supported.
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hmpf hmpf requested a review from podliashanyk July 25, 2023 10:31
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@cf9731a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage        ?   60.02%           
=======================================
  Files           ?        7           
  Lines           ?      968           
  Branches        ?        0           
=======================================
  Hits            ?      581           
  Misses          ?      387           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Test results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 84cf262.

@hmpf hmpf closed this Aug 17, 2023
@hmpf hmpf deleted the pydantic2 branch August 17, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant