Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

personal_sign params are inverted with respect to ether.js #7745

Open
redDwarf03 opened this issue Jul 23, 2024 · 0 comments
Open

personal_sign params are inverted with respect to ether.js #7745

redDwarf03 opened this issue Jul 23, 2024 · 0 comments

Comments

@redDwarf03
Copy link

In ether.js, personal_signhas payload and address params in this order
https://github.com/ethers-io/ethers.js/blob/fc66b8ad405df9e703d42a4b23bc452ec3be118f/src.ts/providers/provider-jsonrpc.ts#L435

In uniswap, we should invert params ? So we need to be specific for this wallet in DApps.

Why this difference please ?
Is it a mistake ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@redDwarf03