Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GUI): remove pack-state buttons #642

Open
3 tasks done
Rudxain opened this issue Sep 22, 2024 · 3 comments
Open
3 tasks done

feat(GUI): remove pack-state buttons #642

Rudxain opened this issue Sep 22, 2024 · 3 comments
Labels
enhancement New feature or request UI Related to the UI

Comments

@Rudxain
Copy link
Member

Rudxain commented Sep 22, 2024

Describe the feature you want

This would simplify the code (less maintenance burden) and it would make the app safer (users are less likely to uninstall on accident)

I believe the "Review selection" button should be the primary way to change the state of 1 or more packages, as it serves as a confirmation-dialog before doing a potentially-irreversible action (pm clear, or potentially trigger a boot-loop)

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@Rudxain Rudxain added enhancement New feature or request UI Related to the UI labels Sep 22, 2024
@Rudxain
Copy link
Member Author

Rudxain commented Sep 22, 2024

BTW, everytime I scroll through the pack-list, I feel anxious, because the mouse is dangerously close to the buttons

@AnonymousWP
Copy link
Member

BTW, everytime I scroll through the pack-list, I feel anxious, because the mouse is dangerously close to the buttons

Maybe we can make confirmation message boxes for the Uninstall and Disable buttons.

@Rudxain
Copy link
Member Author

Rudxain commented Sep 23, 2024

I forgot to mention the other problem: When filtering packs to show "Enabled" only, uninstalling/disabling a pack will make it silently "dissappear" from the (filtered) list, leaving no trace of the action (unless looking at the log). Same thing happens when looking at uninstalled/disabled packs, then restoring 1 or more.

A way to improve this, is to always keep the pack in the current view until the user changes any of the filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI Related to the UI
Projects
None yet
Development

No branches or pull requests

2 participants